Patchwork [2,of,3] logcmdutil: drop default arguments from changesetdisplayer/templater() calls

login
register
mail settings
Submitter Yuya Nishihara
Date Feb. 4, 2018, 11:18 a.m.
Message ID <f1a8a49af81a97618a4b.1517743101@mimosa>
Download mbox | patch
Permalink /patch/27280/
State Accepted
Headers show

Comments

Yuya Nishihara - Feb. 4, 2018, 11:18 a.m.
# HG changeset patch
# User Yuya Nishihara <yuya@tcha.org>
# Date 1516512483 -32400
#      Sun Jan 21 14:28:03 2018 +0900
# Node ID f1a8a49af81a97618a4b1eb7e78c7372db776cdc
# Parent  6815de5ad04ee7cc94071b0806f8859bdc8e6435
logcmdutil: drop default arguments from changesetdisplayer/templater() calls

Patch

diff --git a/hgext/bugzilla.py b/hgext/bugzilla.py
--- a/hgext/bugzilla.py
+++ b/hgext/bugzilla.py
@@ -1091,8 +1091,7 @@  class bugzilla(object):
             tmpl = _('changeset {node|short} in repo {root} refers '
                      'to bug {bug}.\ndetails:\n\t{desc|tabindent}')
         spec = logcmdutil.templatespec(tmpl, mapfile)
-        t = logcmdutil.changesettemplater(self.ui, self.repo, spec,
-                                          False, None, False)
+        t = logcmdutil.changesettemplater(self.ui, self.repo, spec)
         self.ui.pushbuffer()
         t.show(ctx, changes=ctx.changeset(),
                bug=str(bugid),
diff --git a/hgext/journal.py b/hgext/journal.py
--- a/hgext/journal.py
+++ b/hgext/journal.py
@@ -503,8 +503,7 @@  def journal(ui, repo, *args, **opts):
         fm.write('command', '  %s\n', entry.command)
 
         if opts.get("commits"):
-            displayer = logcmdutil.changesetdisplayer(ui, repo, opts,
-                                                      buffered=False)
+            displayer = logcmdutil.changesetdisplayer(ui, repo, opts)
             for hash in entry.newhashes:
                 try:
                     ctx = repo[hash]
diff --git a/hgext/notify.py b/hgext/notify.py
--- a/hgext/notify.py
+++ b/hgext/notify.py
@@ -258,8 +258,7 @@  class notifier(object):
         if not mapfile and not template:
             template = deftemplates.get(hooktype) or single_template
         spec = logcmdutil.templatespec(template, mapfile)
-        self.t = logcmdutil.changesettemplater(self.ui, self.repo, spec,
-                                               False, None, False)
+        self.t = logcmdutil.changesettemplater(self.ui, self.repo, spec)
 
     def strip(self, path):
         '''strip leading slashes from local path, turn into web-safe path.'''
diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
--- a/mercurial/cmdutil.py
+++ b/mercurial/cmdutil.py
@@ -2497,7 +2497,7 @@  def commitforceeditor(repo, ctx, subs, f
 def buildcommittemplate(repo, ctx, subs, extramsg, ref):
     ui = repo.ui
     spec = formatter.templatespec(ref, None, None)
-    t = logcmdutil.changesettemplater(ui, repo, spec, None, {}, False)
+    t = logcmdutil.changesettemplater(ui, repo, spec)
     t.t.cache.update((k, templater.unquotestring(v))
                      for k, v in repo.ui.configitems('committemplate'))