Patchwork [7,of,8] dirstate: drop deprecated methods (API)

login
register
mail settings
Submitter Matt Harbison
Date Feb. 3, 2018, 6:35 a.m.
Message ID <7f21211d4bf3e9cd7a21.1517639703@Envy>
Download mbox | patch
Permalink /patch/27258/
State Accepted
Headers show

Comments

Matt Harbison - Feb. 3, 2018, 6:35 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1517633872 18000
#      Fri Feb 02 23:57:52 2018 -0500
# Node ID 7f21211d4bf3e9cd7a21b2c2bd1fabb69b9b7e94
# Parent  859ae990404c55b790e297a17bd65ccb89cee9cb
dirstate: drop deprecated methods (API)

.. api::

   beginparentchange() and endparentchange() have been replaced by the
   parentchange context manager.

Patch

diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py
--- a/mercurial/dirstate.py
+++ b/mercurial/dirstate.py
@@ -99,27 +99,6 @@ 
         # normally, so we don't have a try/finally here on purpose.
         self._parentwriters -= 1
 
-    def beginparentchange(self):
-        '''Marks the beginning of a set of changes that involve changing
-        the dirstate parents. If there is an exception during this time,
-        the dirstate will not be written when the wlock is released. This
-        prevents writing an incoherent dirstate where the parent doesn't
-        match the contents.
-        '''
-        self._ui.deprecwarn('beginparentchange is obsoleted by the '
-                            'parentchange context manager.', '4.3')
-        self._parentwriters += 1
-
-    def endparentchange(self):
-        '''Marks the end of a set of changes that involve changing the
-        dirstate parents. Once all parent changes have been marked done,
-        the wlock will be free to write the dirstate on release.
-        '''
-        self._ui.deprecwarn('endparentchange is obsoleted by the '
-                            'parentchange context manager.', '4.3')
-        if self._parentwriters > 0:
-            self._parentwriters -= 1
-
     def pendingparentchange(self):
         '''Returns true if the dirstate is in the middle of a set of changes
         that modify the dirstate parent.