Patchwork [5,of,5] check-code: say hi when problems are found

login
register
mail settings
Submitter Mads Kiilerich
Date Oct. 3, 2013, 12:57 p.m.
Message ID <60dd7e4c53448da18d4c.1380805023@mk-desktop>
Download mbox | patch
Permalink /patch/2722/
State Superseded, archived
Headers show

Comments

Mads Kiilerich - Oct. 3, 2013, 12:57 p.m.
# HG changeset patch
# User Mads Kiilerich <madski@unity3d.com>
# Date 1380805015 -7200
#      Thu Oct 03 14:56:55 2013 +0200
# Node ID 60dd7e4c53448da18d4cda340c4031eede4f569f
# Parent  fff081bdc9f40096c5b344703653afd689ce8ea3
check-code: say hi when problems are found

This makes sure that attempts of whitelisting check-code failures will be found
almost immediately.
Augie Fackler - Oct. 3, 2013, 2:42 p.m.
On Thu, Oct 03, 2013 at 02:57:03PM +0200, Mads Kiilerich wrote:
> # HG changeset patch
> # User Mads Kiilerich <madski@unity3d.com>
> # Date 1380805015 -7200
> #      Thu Oct 03 14:56:55 2013 +0200
> # Node ID 60dd7e4c53448da18d4cda340c4031eede4f569f
> # Parent  fff081bdc9f40096c5b344703653afd689ce8ea3
> check-code: say hi when problems are found
>
> This makes sure that attempts of whitelisting check-code failures will be found
> almost immediately.

Queueing 1-4, not sure how I feel about this one so punting. Patch 3
could have stood to be split into more patches for ease of reviewing.

>
> diff --git a/tests/test-check-code-hg.t b/tests/test-check-code-hg.t
> --- a/tests/test-check-code-hg.t
> +++ b/tests/test-check-code-hg.t
> @@ -27,4 +27,5 @@
>  New errors are not allowed. Warnings are strongly discouraged.
>
>    $ { hg manifest 2>/dev/null; ls "$TESTTMP"/*.py | sed 's-\\-/-g'; } |
> -  >   xargs "$check_code" --warnings --per-file=0 || false
> +  >   xargs "$check_code" --warnings --per-file=0 ||
> +  >   { echo; echo "check-code says hi! problems found at `date`"; }
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/tests/test-check-code-hg.t b/tests/test-check-code-hg.t
--- a/tests/test-check-code-hg.t
+++ b/tests/test-check-code-hg.t
@@ -27,4 +27,5 @@ 
 New errors are not allowed. Warnings are strongly discouraged.
 
   $ { hg manifest 2>/dev/null; ls "$TESTTMP"/*.py | sed 's-\\-/-g'; } |
-  >   xargs "$check_code" --warnings --per-file=0 || false
+  >   xargs "$check_code" --warnings --per-file=0 ||
+  >   { echo; echo "check-code says hi! problems found at `date`"; }