Patchwork D1993: discovery: don't reimplement all()

login
register
mail settings
Submitter phabricator
Date Feb. 1, 2018, 11:50 p.m.
Message ID <3a692c50429e2aa0ad2c0350213b0b13@localhost.localdomain>
Download mbox | patch
Permalink /patch/27208/
State Not Applicable
Headers show

Comments

phabricator - Feb. 1, 2018, 11:50 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5523aabb85c3: discovery: don&#039;t reimplement all() (authored by martinvonz, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1993?vs=5117&id=5140

REVISION DETAIL
  https://phab.mercurial-scm.org/D1993

AFFECTED FILES
  mercurial/discovery.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers, indygreg
Cc: mercurial-devel

Patch

diff --git a/mercurial/discovery.py b/mercurial/discovery.py
--- a/mercurial/discovery.py
+++ b/mercurial/discovery.py
@@ -53,13 +53,8 @@ 
         return treediscovery.findcommonincoming(repo, remote, heads, force)
 
     if heads:
-        allknown = True
         knownnode = repo.changelog.hasnode # no nodemap until it is filtered
-        for h in heads:
-            if not knownnode(h):
-                allknown = False
-                break
-        if allknown:
+        if all(knownnode(h) for h in heads):
             return (heads, False, heads)
 
     res = setdiscovery.findcommonheads(repo.ui, repo, remote, heads,