Patchwork D1887: tags: explicitly grab list of dict keys

login
register
mail settings
Submitter phabricator
Date Feb. 1, 2018, 8:33 p.m.
Message ID <ac15abab0e73762a0da3e38e26629a04@localhost.localdomain>
Download mbox | patch
Permalink /patch/27123/
State Not Applicable
Headers show

Comments

phabricator - Feb. 1, 2018, 8:33 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG58aa5adc7d90: tags: explicitly grab list of dict keys (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1887?vs=4877&id=5056

REVISION DETAIL
  https://phab.mercurial-scm.org/D1887

AFFECTED FILES
  mercurial/tags.py

CHANGE DETAILS




To: durin42, #hg-reviewers, pulkit, indygreg
Cc: mercurial-devel

Patch

diff --git a/mercurial/tags.py b/mercurial/tags.py
--- a/mercurial/tags.py
+++ b/mercurial/tags.py
@@ -244,7 +244,7 @@ 
 
     # remove tags pointing to invalid nodes
     cl = repo.changelog
-    for t in filetags.keys():
+    for t in list(filetags):
         try:
             cl.rev(filetags[t][0])
         except (LookupError, ValueError):