Patchwork D1966: wireprotoserver: rename call to callhttp

login
register
mail settings
Submitter phabricator
Date Feb. 1, 2018, 8:19 p.m.
Message ID <differential-rev-PHID-DREV-a54lzgfm6b4rl77wkmuj-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/27116/
State Superseded
Headers show

Comments

phabricator - Feb. 1, 2018, 8:19 p.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  In the context of multiple handlers, call() is ambiguous.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1966

AFFECTED FILES
  mercurial/hgweb/hgweb_mod.py
  mercurial/wireprotoserver.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/wireprotoserver.py b/mercurial/wireprotoserver.py
--- a/mercurial/wireprotoserver.py
+++ b/mercurial/wireprotoserver.py
@@ -146,7 +146,7 @@ 
 def iscmd(cmd):
     return cmd in wireproto.commands
 
-def call(repo, req, cmd):
+def callhttp(repo, req, cmd):
     p = webproto(req, repo.ui)
 
     def genversion2(gen, engine, engineopts):
diff --git a/mercurial/hgweb/hgweb_mod.py b/mercurial/hgweb/hgweb_mod.py
--- a/mercurial/hgweb/hgweb_mod.py
+++ b/mercurial/hgweb/hgweb_mod.py
@@ -368,7 +368,7 @@ 
                     raise ErrorResponse(HTTP_NOT_FOUND)
                 if cmd in perms:
                     self.check_perm(rctx, req, perms[cmd])
-                return wireprotoserver.call(rctx.repo, req, cmd)
+                return wireprotoserver.callhttp(rctx.repo, req, cmd)
             except ErrorResponse as inst:
                 # A client that sends unbundle without 100-continue will
                 # break if we respond early.