Patchwork [4,of,4,STABLE,follow-up] streamclone: add a comment about non-publishing being broken with v1

login
register
mail settings
Submitter Boris Feld
Date Jan. 26, 2018, 4:07 p.m.
Message ID <8029e760bb1d7cfd1bb6.1516982852@FB>
Download mbox | patch
Permalink /patch/27068/
State Accepted
Headers show

Comments

Boris Feld - Jan. 26, 2018, 4:07 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1516978902 -3600
#      Fri Jan 26 16:01:42 2018 +0100
# Branch stable
# Node ID 8029e760bb1d7cfd1bb61b7db907fe3c193b7ae6
# Parent  17f4ad0dca3214da14031b33359eec4c1684f75a
# EXP-Topic b2-stream
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 8029e760bb1d
streamclone: add a comment about non-publishing being broken with v1

This change was suggested by Gregory Szorc.

Patch

diff --git a/tests/test-clone-uncompressed.t b/tests/test-clone-uncompressed.t
--- a/tests/test-clone-uncompressed.t
+++ b/tests/test-clone-uncompressed.t
@@ -479,6 +479,10 @@  Clone as non publishing
   $ cat hg.pid > $DAEMON_PIDS
 
 #if stream-legacy
+
+With v1 of the stream protocol, changeset are always cloned as public. It make
+stream v1 unsuitable for non-publishing repository.
+
   $ hg clone --stream http://localhost:$HGPORT phase-no-publish
   streaming all changes
   1027 files to transfer, 96.3 KB of data