Patchwork D1906: revlog: correct type in check to verify rawtext is immutable

login
register
mail settings
Submitter phabricator
Date Jan. 19, 2018, 8:12 p.m.
Message ID <cb68d4d8eca76e5fe1b747c97c41dd86@localhost.localdomain>
Download mbox | patch
Permalink /patch/26977/
State Not Applicable
Headers show

Comments

phabricator - Jan. 19, 2018, 8:12 p.m.
durin42 updated this revision to Diff 4952.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1906?vs=4911&id=4952

REVISION DETAIL
  https://phab.mercurial-scm.org/D1906

AFFECTED FILES
  mercurial/revlog.py

CHANGE DETAILS




To: durin42, indygreg, #hg-reviewers, pulkit
Cc: mercurial-devel

Patch

diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -2099,7 +2099,7 @@ 
         if alwayscache and rawtext is None:
             rawtext = deltacomputer._buildtext(revinfo, fh)
 
-        if type(rawtext) == str: # only accept immutable objects
+        if type(rawtext) == bytes: # only accept immutable objects
             self._cache = (node, curr, rawtext)
         self._chainbasecache[curr] = chainbase
         return node