Patchwork D1855: explicitly kill server processes

login
register
mail settings
Submitter phabricator
Date Jan. 12, 2018, 4:13 p.m.
Message ID <differential-rev-PHID-DREV-s2nlrhvlri6vqetru7up-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/26705/
State Superseded
Headers show

Comments

phabricator - Jan. 12, 2018, 4:13 p.m.
joerg.sonnenberger created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1855

AFFECTED FILES
  tests/test-pull-r.t

CHANGE DETAILS




To: joerg.sonnenberger, #hg-reviewers
Cc: mercurial-devel
phabricator - Jan. 13, 2018, 2:47 a.m.
yuja added a comment.


  Just for the record, explicit killdaemon isn't needed unless you want
  to do something (e.g. checking server logs) after that. Daemons are
  kill by the test runner.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1855

To: joerg.sonnenberger, #hg-reviewers, indygreg
Cc: yuja, mercurial-devel
phabricator - Jan. 17, 2018, 5:41 p.m.
martinvonz added a comment.


  In https://phab.mercurial-scm.org/D1855#31400, @yuja wrote:
  
  > Just for the record, explicit killdaemon isn't needed unless you want
  >  to do something (e.g. checking server logs) after that. Daemons are
  >  kill by the test runner.
  
  
  So what was the reason for this patch?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1855

To: joerg.sonnenberger, #hg-reviewers, indygreg
Cc: martinvonz, yuja, mercurial-devel
phabricator - Jan. 17, 2018, 6:24 p.m.
martinvonz added a comment.


  In https://phab.mercurial-scm.org/D1855#31684, @martinvonz wrote:
  
  > In https://phab.mercurial-scm.org/D1855#31400, @yuja wrote:
  >
  > > Just for the record, explicit killdaemon isn't needed unless you want
  > >  to do something (e.g. checking server logs) after that. Daemons are
  > >  kill by the test runner.
  >
  >
  > So what was the reason for this patch?
  
  
  I found https://phab.mercurial-scm.org/rHGbc7377160fa732f4c22682bc98c09b76490ca137 that adds this line and a comment saying "Explicitly kill daemons to let the test exit on Windows". Unfortunately, it doesn't explain any more than that. Is Joerg also running on Windows and maybe had the same problem (that the test doesn't exit, whatever that means)?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1855

To: joerg.sonnenberger, #hg-reviewers, indygreg
Cc: martinvonz, yuja, mercurial-devel
phabricator - Jan. 17, 2018, 11:14 p.m.
joerg.sonnenberger added a comment.


  It was preparation for more tests here. Since I am moving them to a separate file now, I'm not really attached to it at all.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1855

To: joerg.sonnenberger, #hg-reviewers, indygreg
Cc: martinvonz, yuja, mercurial-devel

Patch

diff --git a/tests/test-pull-r.t b/tests/test-pull-r.t
--- a/tests/test-pull-r.t
+++ b/tests/test-pull-r.t
@@ -144,3 +144,4 @@ 
   
 
   $ cd ..
+  $ killdaemons.py