Patchwork D1847: rust: add TODO about lifetime of program_name variable

login
register
mail settings
Submitter phabricator
Date Jan. 11, 2018, 3:42 a.m.
Message ID <differential-rev-PHID-DREV-lh6aoy27dlnk2dyjbcqo-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/26675/
State Superseded
Headers show

Comments

phabricator - Jan. 11, 2018, 3:42 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Per review comment in https://phab.mercurial-scm.org/D1581.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1847

AFFECTED FILES
  rust/hgcli/src/main.rs

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/rust/hgcli/src/main.rs b/rust/hgcli/src/main.rs
--- a/rust/hgcli/src/main.rs
+++ b/rust/hgcli/src/main.rs
@@ -125,6 +125,9 @@ 
     // Set program name. The backing memory needs to live for the duration of the
     // interpreter.
     //
+    // TODO consider storing this in a static or associating with lifetime of
+    // the Python interpreter.
+    //
     // Yes, we use the path to the Python interpreter not argv[0] here. The
     // reason is because Python uses the given path to find the location of
     // Python files. Apparently we could define our own ``Py_GetPath()``