Patchwork D1809: tests: switch test from '--config ui.editor=~/foo' to HGEDITOR=~/foo

login
register
mail settings
Submitter phabricator
Date Jan. 5, 2018, 12:29 a.m.
Message ID <differential-rev-PHID-DREV-3r5ygc6qtwhg5b6qotne-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/26544/
State Superseded
Headers show

Comments

phabricator - Jan. 5, 2018, 12:29 a.m.
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The test is currently not testing anything, the '--config ui.editor=~/path'
  argument is apparently of lower priority than the HGEDITOR that run-tests.py is
  setting.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1809

AFFECTED FILES
  tests/test-install.t

CHANGE DETAILS




To: spectral, #hg-reviewers
Cc: mercurial-devel
phabricator - Jan. 5, 2018, 3:24 a.m.
krbullock accepted this revision.
krbullock added a comment.
This revision is now accepted and ready to land.


  Queued, thanks

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1809

To: spectral, #hg-reviewers, krbullock
Cc: krbullock, mercurial-devel

Patch

diff --git a/tests/test-install.t b/tests/test-install.t
--- a/tests/test-install.t
+++ b/tests/test-install.t
@@ -98,7 +98,7 @@ 
 #if execbit
   $ chmod 755 tools/testeditor.exe
 #endif
-  $ hg debuginstall --config ui.editor=~/tools/testeditor.exe
+  $ HGEDITOR="~/tools/testeditor.exe" hg debuginstall
   checking encoding (ascii)...
   checking Python executable (*) (glob)
   checking Python version (*) (glob)
@@ -116,7 +116,7 @@ 
   checking "re2" regexp engine \((available|missing)\) (re)
   checking templates (*mercurial?templates)... (glob)
   checking default template (*mercurial?templates?map-cmdline.default) (glob)
-  checking commit editor... (* -c "import sys; sys.exit(0)") (glob)
+  checking commit editor... ($TESTTMP/tools/testeditor.exe)
   checking username (test)
   no problems detected