Patchwork test-convert-cvs: change TZ=US/Hawaii to TZ=Pacific/Johnston

login
register
mail settings
Submitter Elmar Bartel
Date Jan. 1, 2018, 5:20 p.m.
Message ID <5206245f023fbf64abe6.1514827232@nuc15.leo.org>
Download mbox | patch
Permalink /patch/26527/
State Accepted
Headers show

Comments

Elmar Bartel - Jan. 1, 2018, 5:20 p.m.
# HG changeset patch
# User Elmar Bartel <elb@leo.org>
# Date 1514821711 -3600
#      Mon Jan 01 16:48:31 2018 +0100
# Node ID 5206245f023fbf64abe6c99bc93a0ac7d451f588
# Parent  eac82bbc886901b154516afe3e742eb5aa96c917
test-convert-cvs: change TZ=US/Hawaii to TZ=Pacific/Johnston
The former was limited to be known on Linux and the test failed
on FreeBSD and Solaris platforms.
The newer is known on Linux, FreeBSD and Solaris.
Yuya Nishihara - Jan. 4, 2018, 7:31 a.m.
On Mon, 01 Jan 2018 18:20:32 +0100, Elmar Bartel wrote:
> # HG changeset patch
> # User Elmar Bartel <elb@leo.org>
> # Date 1514821711 -3600
> #      Mon Jan 01 16:48:31 2018 +0100
> # Node ID 5206245f023fbf64abe6c99bc93a0ac7d451f588
> # Parent  eac82bbc886901b154516afe3e742eb5aa96c917
> test-convert-cvs: change TZ=US/Hawaii to TZ=Pacific/Johnston
> The former was limited to be known on Linux and the test failed
> on FreeBSD and Solaris platforms.
> The newer is known on Linux, FreeBSD and Solaris.

Seems fine, queued, thanks.

Patch

diff -r eac82bbc8869 -r 5206245f023f tests/test-convert-cvs.t
--- a/tests/test-convert-cvs.t	Sun Dec 31 18:04:26 2017 +0100
+++ b/tests/test-convert-cvs.t	Mon Jan 01 16:48:31 2018 +0100
@@ -80,7 +80,12 @@  An arbitrary (U.S.) time zone is used he
 since it does not use DST (unlike other U.S. time zones) and is always
 a fixed difference from UTC.
 
-  $ TZ=US/Hawaii hg convert --config convert.localtimezone=True src src-hg
+This choice is limited to work on Linux environments. At least on
+FreeBSD 11 this timezone is not known. A better choice is
+TZ=Pacific/Johnston. On Linux "US/Hawaii" is just a symlink to this
+name and also it is known on FreeBSD and on Solaris.
+
+  $ TZ=Pacific/Johnston hg convert --config convert.localtimezone=True src src-hg
   initializing destination src-hg repository
   connecting to $TESTTMP/cvsrepo
   scanning source...
@@ -170,7 +175,7 @@  commit new file revisions
 
 convert again
 
-  $ TZ=US/Hawaii hg convert --config convert.localtimezone=True src src-hg
+  $ TZ=Pacific/Johnston hg convert --config convert.localtimezone=True src src-hg
   connecting to $TESTTMP/cvsrepo
   scanning source...
   collecting CVS rlog
@@ -231,7 +236,7 @@  commit branch
 
 convert again
 
-  $ TZ=US/Hawaii hg convert --config convert.localtimezone=True src src-hg
+  $ TZ=Pacific/Johnston hg convert --config convert.localtimezone=True src src-hg
   connecting to $TESTTMP/cvsrepo
   scanning source...
   collecting CVS rlog
@@ -249,7 +254,7 @@  convert again
 
 convert again with --filemap
 
-  $ TZ=US/Hawaii hg convert --config convert.localtimezone=True --filemap filemap src src-filemap
+  $ TZ=Pacific/Johnston hg convert --config convert.localtimezone=True --filemap filemap src src-filemap
   connecting to $TESTTMP/cvsrepo
   scanning source...
   collecting CVS rlog
@@ -296,7 +301,7 @@  commit new file revisions with some fuzz
 
 convert again
 
-  $ TZ=US/Hawaii hg convert --config convert.cvsps.fuzz=2 --config convert.localtimezone=True src src-hg
+  $ TZ=Pacific/Johnston hg convert --config convert.cvsps.fuzz=2 --config convert.localtimezone=True src src-hg
   connecting to $TESTTMP/cvsrepo
   scanning source...
   collecting CVS rlog