Patchwork D1761: scmutil: use a tuple of possible values instead of using startswith()

login
register
mail settings
Submitter phabricator
Date Dec. 27, 2017, 12:43 p.m.
Message ID <58430496f3bdd102a05f9d0cbaaf5192@localhost.localdomain>
Download mbox | patch
Permalink /patch/26472/
State Not Applicable
Headers show

Comments

phabricator - Dec. 27, 2017, 12:43 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGb55a142f00c5: scmutil: use a tuple of possible values instead of using startswith() (authored by pulkit, committed by ).

CHANGED PRIOR TO COMMIT
  https://phab.mercurial-scm.org/D1761?vs=4622&id=4641#toc

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1761?vs=4622&id=4641

REVISION DETAIL
  https://phab.mercurial-scm.org/D1761

AFFECTED FILES
  mercurial/scmutil.py

CHANGE DETAILS




To: pulkit, #hg-reviewers, yuja
Cc: mercurial-devel

Patch

diff --git a/mercurial/scmutil.py b/mercurial/scmutil.py
--- a/mercurial/scmutil.py
+++ b/mercurial/scmutil.py
@@ -1319,7 +1319,7 @@ 
                                                      'directaccess'):
         return repo
 
-    if not repo.filtername.startswith('visible'):
+    if repo.filtername not in ('visible', 'visible-hidden'):
         return repo
 
     symbols = set()
@@ -1345,6 +1345,8 @@ 
         repo.ui.warn(_("warning: accessing hidden changesets for write "
                        "operation: %s\n") % revstr)
 
+    # we have to use new filtername to separate branch/tags cache until we can
+    # disbale these cache when revisions are dynamically pinned.
     return repo.filtered('visible-hidden', revs)
 
 def _getrevsfromsymbols(repo, symbols):