Patchwork D1724: githelp: remove help for `git am`

login
register
mail settings
Submitter phabricator
Date Dec. 19, 2017, 5:36 a.m.
Message ID <differential-rev-PHID-DREV-3euzjuo4tw3wluksd6rw-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/26350/
State Superseded
Headers show

Comments

phabricator - Dec. 19, 2017, 5:36 a.m.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This referenced a third party extension. It doesn't feel appropriate
  to do that from a core extension.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1724

AFFECTED FILES
  hgext/githelp.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel
phabricator - Dec. 21, 2017, 1:38 a.m.
durin42 added a comment.


  what's wrong with `hg import`? Doesn't that correctly parses mbox files?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1724

To: indygreg, #hg-reviewers
Cc: durin42, mercurial-devel

Patch

diff --git a/hgext/githelp.py b/hgext/githelp.py
--- a/hgext/githelp.py
+++ b/hgext/githelp.py
@@ -170,14 +170,6 @@ 
 
     ui.status((str(cmd)), "\n")
 
-def am(ui, repo, *args, **kwargs):
-    cmdoptions=[
-    ]
-    args, opts = parseoptions(ui, cmdoptions, args)
-    cmd = Command('mimport -m')
-    ui.status(str(cmd), "\n\n")
-    ui.status(_("note: requires the MboxExtension and the MqExtension.\n"))
-
 def apply(ui, repo, *args, **kwargs):
     cmdoptions = [
         ('p', 'p', int, ''),
@@ -1030,7 +1022,6 @@ 
 
 gitcommands = {
     'add': add,
-    'am': am,
     'apply': apply,
     'bisect': bisect,
     'blame': blame,