Patchwork D1720: debug: add newlines at the end of three locations that appear to need it

login
register
mail settings
Submitter phabricator
Date Dec. 19, 2017, 1:48 a.m.
Message ID <differential-rev-PHID-DREV-glvkl7iowzi2nuk3duw3-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/26343/
State Superseded
Headers show

Comments

phabricator - Dec. 19, 2017, 1:48 a.m.
spectral created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1720

AFFECTED FILES
  hgext/patchbomb.py
  mercurial/bundle2.py
  mercurial/dispatch.py

CHANGE DETAILS




To: spectral, #hg-reviewers
Cc: mercurial-devel
phabricator - Dec. 21, 2017, 11:01 p.m.
krbullock accepted this revision.
krbullock added a comment.
This revision is now accepted and ready to land.


  Sure, queued.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1720

To: spectral, #hg-reviewers, krbullock
Cc: krbullock, mercurial-devel

Patch

diff --git a/mercurial/dispatch.py b/mercurial/dispatch.py
--- a/mercurial/dispatch.py
+++ b/mercurial/dispatch.py
@@ -451,7 +451,7 @@ 
                         return m.group()
                     else:
                         ui.debug("No argument found for substitution "
-                                 "of %i variable in alias '%s' definition."
+                                 "of %i variable in alias '%s' definition.\n"
                                  % (int(m.groups()[0]), self.name))
                         return ''
                 cmd = re.sub(br'\$(\d+|\$)', _checkvar, self.definition[1:])
diff --git a/mercurial/bundle2.py b/mercurial/bundle2.py
--- a/mercurial/bundle2.py
+++ b/mercurial/bundle2.py
@@ -2056,7 +2056,7 @@ 
     # The mergemarkers call will crash if marker creation is not enabled.
     # we want to avoid this if the part is advisory.
     if not inpart.mandatory and op.repo.obsstore.readonly:
-        op.repo.ui.debug('ignoring obsolescence markers, feature not enabled')
+        op.repo.ui.debug('ignoring obsolescence markers, feature not enabled\n')
         return
     new = op.repo.obsstore.mergemarkers(tr, markerdata)
     op.repo.invalidatevolatilesets()
diff --git a/hgext/patchbomb.py b/hgext/patchbomb.py
--- a/hgext/patchbomb.py
+++ b/hgext/patchbomb.py
@@ -632,15 +632,15 @@ 
     # check if revision exist on the public destination
     publicurl = repo.ui.config('patchbomb', 'publicurl')
     if publicurl:
-        repo.ui.debug('checking that revision exist in the public repo')
+        repo.ui.debug('checking that revision exist in the public repo\n')
         try:
             publicpeer = hg.peer(repo, {}, publicurl)
         except error.RepoError:
             repo.ui.write_err(_('unable to access public repo: %s\n')
                               % publicurl)
             raise
         if not publicpeer.capable('known'):
-            repo.ui.debug('skipping existence checks: public repo too old')
+            repo.ui.debug('skipping existence checks: public repo too old\n')
         else:
             out = [repo[r] for r in revs]
             known = publicpeer.known(h.node() for h in out)