Patchwork D1715: completion: don't suggest clean files to revert

login
register
mail settings
Submitter phabricator
Date Dec. 18, 2017, 7:25 p.m.
Message ID <differential-rev-PHID-DREV-rpqsg6o7k45dygcg5jmz-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/26337/
State Superseded
Headers show

Comments

phabricator - Dec. 18, 2017, 7:25 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  It looks like we used to suggest only modified, added, removed and
  deleted files to revert until https://phab.mercurial-scm.org/rHGa821ec835223492b9605e4804abfaaec8700cbb3 (completion: selectively
  use debugpathcomplete in bash_completion, 2013-03-21). The reasoning
  in that commit was that getting the status was too slow and the
  replacement (debugpathcomplete) seems to make sense for the other two
  commands (remove and forget), but I'm not sure it was intentional to
  change the behavior of completion for revert. Note that "add" and
  "diff" already use status-based completion.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1715

AFFECTED FILES
  contrib/bash_completion

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/contrib/bash_completion b/contrib/bash_completion
--- a/contrib/bash_completion
+++ b/contrib/bash_completion
@@ -309,7 +309,7 @@ 
             _hg_status "mar"
         ;;
         revert)
-            _hg_debugpathcomplete
+            _hg_status "mard"
         ;;
         clone)
             local count=$(_hg_count_non_option)