Patchwork D1667: tests_: fix test-lfs.t on OSX where find does not have quotes

login
register
mail settings
Submitter phabricator
Date Dec. 12, 2017, 7:42 p.m.
Message ID <differential-rev-PHID-DREV-kyxmd6edfh42jh67dunk-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/26241/
State Superseded
Headers show

Comments

phabricator - Dec. 12, 2017, 7:42 p.m.
ikostia created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

TEST PLAN
  - run test-lfs.t

REPOSITORY
  rHG Mercurial

BRANCH
  default

REVISION DETAIL
  https://phab.mercurial-scm.org/D1667

AFFECTED FILES
  tests/test-lfs.t

CHANGE DETAILS




To: ikostia, #hg-reviewers
Cc: mercurial-devel
phabricator - Dec. 12, 2017, 8:13 p.m.
akushner accepted this revision.
akushner added a comment.


  Why was there a quote on Linux? I didn't see a quote when I ran the find command.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1667

To: ikostia, #hg-reviewers, quark, akushner
Cc: akushner, mercurial-devel
phabricator - Dec. 12, 2017, 9:34 p.m.
durin42 added a comment.


  Beat you to it: https://www.mercurial-scm.org/repo/hg-committed/rev/85f866bf9362

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1667

To: ikostia, #hg-reviewers, quark, akushner
Cc: durin42, akushner, mercurial-devel
phabricator - Dec. 12, 2017, 9:34 p.m.
quark added a comment.


  In https://phab.mercurial-scm.org/D1667#28537, @akushner wrote:
  
  > Why was there a quote on Linux? I didn't see a quote when I ran the find command.
  
  
  coreutils (starting from some version) added quotes by default if it finds special characters in paths: https://unix.stackexchange.com/questions/258679/why-is-ls-suddenly-wrapping-items-with-spaces-in-single-quotes
  
  I think some distros have that disabled by default.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1667

To: ikostia, #hg-reviewers, quark, akushner
Cc: durin42, akushner, mercurial-devel
phabricator - Dec. 12, 2017, 9:34 p.m.
durin42 added a comment.


  (and yes, I'm curious where that ' came from too, but here we are)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1667

To: ikostia, #hg-reviewers, quark, akushner
Cc: durin42, akushner, mercurial-devel
phabricator - Dec. 12, 2017, 9:36 p.m.
quark added a comment.


  @ikostia This Phabricator instance should support "tests:" in title so there is no need to workaround that by using an underscore.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1667

To: ikostia, #hg-reviewers, quark, akushner
Cc: durin42, akushner, mercurial-devel
phabricator - Dec. 13, 2017, 10:24 a.m.
ikostia abandoned this revision.
ikostia added a comment.


  @quark: thanks for the `tests` note.
  
  abandoning this as an equivalent change is already landed.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1667

To: ikostia, #hg-reviewers, quark, akushner
Cc: durin42, akushner, mercurial-devel

Patch

diff --git a/tests/test-lfs.t b/tests/test-lfs.t
--- a/tests/test-lfs.t
+++ b/tests/test-lfs.t
@@ -571,7 +571,7 @@ 
 the user cache.
 
   $ find $TESTTMP/repo12/.hg/store/lfs/objects -type f
-  find: */repo12/.hg/store/lfs/objects': $ENOENT$ (glob)
+  find: */repo12/.hg/store/lfs/objects*: $ENOENT$ (glob)
   [1]
 
   $ hg --config extensions.share= share repo12 repo13