Patchwork D1653: tests: add some commentary and diagnostics to test-run-tests.t

login
register
mail settings
Submitter phabricator
Date Dec. 11, 2017, 2:37 p.m.
Message ID <differential-rev-PHID-DREV-uaf3ht2dmdv2vovijfzl-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/26216/
State Superseded
Headers show

Comments

phabricator - Dec. 11, 2017, 2:37 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Hopefully this will give us a shot at fixing it on the Windows builder.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1653

AFFECTED FILES
  tests/test-run-tests.t

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
--- a/tests/test-run-tests.t
+++ b/tests/test-run-tests.t
@@ -1214,7 +1214,12 @@ 
   > #else
   >   $ test "\$TESTDIR" = "$TESTTMP"/anothertests
   > #endif
-  >   $ test "\$RUNTESTDIR" = "$TESTDIR"
+  > If this prints a path, that means RUNTESTDIR didn't equal
+  > TESTDIR as it should have.
+  >   $ test "\$RUNTESTDIR" = "$TESTDIR" || echo "\$RUNTESTDIR"
+  > This should print the start of check-code. If this passes but the
+  > previous check failed, that means we found a copy of check-code at whatever
+  > RUNTESTSDIR ended up containing, even though it doesn't match TESTDIR.
   >   $ head -n 3 "\$RUNTESTDIR"/../contrib/check-code.py | sed 's@.!.*python@#!USRBINENVPY@'
   >   #!USRBINENVPY
   >   #