Patchwork D1647: py3: handle keyword arguments correctly in wireproto.py

login
register
mail settings
Submitter phabricator
Date Dec. 10, 2017, 2:41 a.m.
Message ID <differential-rev-PHID-DREV-ufttjq7tyscxkpiylmhm-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/26181/
State Superseded
Headers show

Comments

phabricator - Dec. 10, 2017, 2:41 a.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1647

AFFECTED FILES
  mercurial/wireproto.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/wireproto.py b/mercurial/wireproto.py
--- a/mercurial/wireproto.py
+++ b/mercurial/wireproto.py
@@ -452,9 +452,9 @@ 
         # don't pass optional arguments left at their default value
         opts = {}
         if three is not None:
-            opts['three'] = three
+            opts[r'three'] = three
         if four is not None:
-            opts['four'] = four
+            opts[r'four'] = four
         return self._call('debugwireargs', one=one, two=two, **opts)
 
     def _call(self, cmd, **args):
@@ -817,7 +817,7 @@ 
 def debugwireargs(repo, proto, one, two, others):
     # only accept optional args from the known set
     opts = options('debugwireargs', ['three', 'four'], others)
-    return repo.debugwireargs(one, two, **opts)
+    return repo.debugwireargs(one, two, **pycompat.strkwargs(opts))
 
 @wireprotocommand('getbundle', '*')
 def getbundle(repo, proto, others):