Patchwork [1,of,6] upgrade: rename 'removecldeltachain' to 'plain-cl-delta'

login
register
mail settings
Submitter Boris Feld
Date Dec. 8, 2017, 10:58 a.m.
Message ID <88ae8b7114e294c3bc64.1512730680@FB>
Download mbox | patch
Permalink /patch/26090/
State Accepted
Headers show

Comments

Boris Feld - Dec. 8, 2017, 10:58 a.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1512658559 -3600
#      Thu Dec 07 15:55:59 2017 +0100
# Node ID 88ae8b7114e294c3bc641611324f1a7b023a1f5e
# Parent  483b5dd0f1aa412e9611ab694279c9d3735fee99
# EXP-Topic upgrade
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r 88ae8b7114e2
upgrade: rename 'removecldeltachain' to 'plain-cl-delta'

The new naming is more descriptive of a "state" while the older one was more
about "action". I'm looking into command exposing more of data about the state
of the repository so "state" oriented work better there.

The key has not been made public anywhere outside the debug area so it is fine
to update it.
Gregory Szorc - Dec. 9, 2017, 5:30 a.m.
On Fri, Dec 8, 2017 at 2:58 AM, Boris Feld <boris.feld@octobus.net> wrote:

> # HG changeset patch
> # User Boris Feld <boris.feld@octobus.net>
> # Date 1512658559 -3600
> #      Thu Dec 07 15:55:59 2017 +0100
> # Node ID 88ae8b7114e294c3bc641611324f1a7b023a1f5e
> # Parent  483b5dd0f1aa412e9611ab694279c9d3735fee99
> # EXP-Topic upgrade
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r
> 88ae8b7114e2
> upgrade: rename 'removecldeltachain' to 'plain-cl-delta'
>

Queued this series.

That new debug command is useful and concise! I'm not a huge fan of
"format" as a user-facing name. But it already exists in hgrc and it is a
debug command, so it isn't worth bikeshedding.

I'm also curious to see where the compression series goes.


>
> The new naming is more descriptive of a "state" while the older one was
> more
> about "action". I'm looking into command exposing more of data about the
> state
> of the repository so "state" oriented work better there.
>
> The key has not been made public anywhere outside the debug area so it is
> fine
> to update it.
>
> diff --git a/mercurial/upgrade.py b/mercurial/upgrade.py
> --- a/mercurial/upgrade.py
> +++ b/mercurial/upgrade.py
> @@ -259,7 +259,7 @@ class generaldelta(requirementformatvari
>
>  @registerformatvariant
>  class removecldeltachain(formatvariant):
> -    name = 'removecldeltachain'
> +    name = 'plain-cl-delta'
>
>      default = True
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>

Patch

diff --git a/mercurial/upgrade.py b/mercurial/upgrade.py
--- a/mercurial/upgrade.py
+++ b/mercurial/upgrade.py
@@ -259,7 +259,7 @@  class generaldelta(requirementformatvari
 
 @registerformatvariant
 class removecldeltachain(formatvariant):
-    name = 'removecldeltachain'
+    name = 'plain-cl-delta'
 
     default = True