Patchwork D1216: overlayworkingctx: remove flushall()

login
register
mail settings
Submitter phabricator
Date Dec. 7, 2017, 7:49 p.m.
Message ID <22c4706843920d6128394bcd6e5bb122@localhost.localdomain>
Download mbox | patch
Permalink /patch/26006/
State Not Applicable
Headers show

Comments

phabricator - Dec. 7, 2017, 7:49 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG3ceebf497057: overlayworkingctx: remove flushall() (authored by phillco, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1216?vs=4039&id=4172

REVISION DETAIL
  https://phab.mercurial-scm.org/D1216

AFFECTED FILES
  mercurial/context.py

CHANGE DETAILS




To: phillco, #hg-reviewers, durin42
Cc: mercurial-devel, martinvonz

Patch

diff --git a/mercurial/context.py b/mercurial/context.py
--- a/mercurial/context.py
+++ b/mercurial/context.py
@@ -1653,9 +1653,6 @@ 
                               listsubrepos=listsubrepos, badfn=badfn,
                               icasefs=icasefs)
 
-    def flushall(self):
-        pass # For overlayworkingfilectx compatibility.
-
     def _filtersuspectsymlink(self, files):
         if not files or self._repo.dirstate._checklink:
             return files
@@ -2074,36 +2071,13 @@ 
                                              self._path)
         return self._wrappedctx[path].size()
 
-    def flushall(self):
-        for path in self._writeorder:
-            entry = self._cache[path]
-            if entry['exists']:
-                self._wrappedctx[path].clearunknown()
-                if entry['data'] is not None:
-                    if entry['flags'] is None:
-                        raise error.ProgrammingError('data set but not flags')
-                    self._wrappedctx[path].write(
-                        entry['data'],
-                        entry['flags'])
-                else:
-                    self._wrappedctx[path].setflags(
-                        'l' in entry['flags'],
-                        'x' in entry['flags'])
-            else:
-                self._wrappedctx[path].remove(path)
-        self._clean()
-
     def isdirty(self, path):
         return path in self._cache
 
     def _clean(self):
         self._cache = {}
-        self._writeorder = []
 
     def _markdirty(self, path, exists, data=None, date=None, flags=''):
-        if path not in self._cache:
-            self._writeorder.append(path)
-
         self._cache[path] = {
             'exists': exists,
             'data': data,