Patchwork [1,of,3] lfs-test: note a problem with unpushed lfs files and cloning/sharing

login
register
mail settings
Submitter Matt Harbison
Date Dec. 7, 2017, 5:29 a.m.
Message ID <a7be2d8c84f3c039d1be.1512624546@Envy>
Download mbox | patch
Permalink /patch/25986/
State Accepted
Headers show

Comments

Matt Harbison - Dec. 7, 2017, 5:29 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1510884315 18000
#      Thu Nov 16 21:05:15 2017 -0500
# Node ID a7be2d8c84f3c039d1be507328b04bfd89f2901f
# Parent  205c3c6c1a514d85b3a135e3515ce1a76206e8ac
lfs-test: note a problem with unpushed lfs files and cloning/sharing

AFAIK, this isn't an issue with largefiles because it knows how to look in the
system-wide cache.

Patch

diff --git a/tests/test-lfs.t b/tests/test-lfs.t
--- a/tests/test-lfs.t
+++ b/tests/test-lfs.t
@@ -566,6 +566,35 @@ 
   repo: repo9
   repo: repo10
 
+TODO: repo12 doesn't have any cached lfs files.  Figure out how to get the
+unpushed files from repo12's source instead of the remote store, where they
+don't exist.
+
+  $ find $TESTTMP/repo12/.hg/store/lfs/objects -type f
+  find: */repo12/.hg/store/lfs/objects': $ENOENT$ (glob)
+  [1]
+
+  $ hg --config extensions.share= share repo12 repo13
+  updating working directory
+  abort: $TESTTMP/dummy-remote/09/66faba9a01f6c78082aa45899a4fef732002d0b26404e90093adf1e876ab8d: $ENOTDIR$ (glob)
+  [255]
+  $ hg clone repo12 repo14
+  updating to branch default
+  abort: $TESTTMP/dummy-remote/09/66faba9a01f6c78082aa45899a4fef732002d0b26404e90093adf1e876ab8d: $ENOTDIR$ (glob)
+  [255]
+
+TODO: If the source repo doesn't have the blob (maybe it was pulled or cloned
+with --noupdate), the blob should be accessible via the global cache to send to
+the remote store.
+
+  $ rm -rf $TESTTMP/repo14/.hg/store/lfs
+  $ hg init repo15
+  $ hg -R repo14 push repo15
+  pushing to repo15
+  searching for changes
+  abort: $TESTTMP/repo14/.hg/store/lfs/objects/1c/896a0adcf9262119f4a98216aaa5ca00a58b9a0ce848914a02f9cd876f65a3: $ENOTDIR$ (glob)
+  [255]
+
 lfs -> normal -> lfs round trip conversions are possible.  The threshold for the
 lfs destination is specified here because it was originally listed in the local
 .hgrc, and the global one is too high to trigger lfs usage.  For lfs -> normal,