Patchwork D1598: contrib: ban find(1)'s -printf operator, as it is a GNU-ism

login
register
mail settings
Submitter phabricator
Date Dec. 6, 2017, 2:37 p.m.
Message ID <7711f22ec1ad695622b1bb8ecd0c54e9@localhost.localdomain>
Download mbox | patch
Permalink /patch/25967/
State Not Applicable
Headers show

Comments

phabricator - Dec. 6, 2017, 2:37 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG22956c17aa18: contrib: ban find(1)&#039;s -printf operator, as it is a GNU-ism (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1598?vs=4135&id=4153

REVISION DETAIL
  https://phab.mercurial-scm.org/D1598

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: durin42, #hg-reviewers, yuja
Cc: mercurial-devel

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -149,6 +149,8 @@ 
     (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"),
     (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"),
     (r'grep.* -[ABC]', "don't use grep's context flags"),
+    (r'find.*-printf',
+     "don't use 'find -printf', it doesn't exist on BSD find(1)"),
   ],
   # warnings
   [