Patchwork D1605: tests: remove {a..h} bashism from remotenames

login
register
mail settings
Submitter phabricator
Date Dec. 6, 2017, 2:25 p.m.
Message ID <differential-rev-PHID-DREV-mukdvnzfmzm6mf7ffwme-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25966/
State Superseded
Headers show

Comments

phabricator - Dec. 6, 2017, 2:25 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I'm not bothering with a check-code test because this is a weird
  construct that I didn't even know existed before it was breaking the
  BSD build.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1605

AFFECTED FILES
  tests/test-remotenames.t

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel
phabricator - Dec. 6, 2017, 2:45 p.m.
pulkit accepted this revision.
pulkit added a comment.


  Sigh, thanks again for fixing this. I will make sure I stop using this pattern.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1605

To: durin42, #hg-reviewers, pulkit
Cc: pulkit, mercurial-devel
phabricator - Dec. 6, 2017, 7:43 p.m.
krbullock accepted this revision.
krbullock added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1605

To: durin42, #hg-reviewers, pulkit, krbullock
Cc: krbullock, pulkit, mercurial-devel

Patch

diff --git a/tests/test-remotenames.t b/tests/test-remotenames.t
--- a/tests/test-remotenames.t
+++ b/tests/test-remotenames.t
@@ -11,7 +11,10 @@ 
 
   $ hg init server
   $ cd server
-  $ for ch in {a..h}; do echo "foo" >> $ch; hg ci -Aqm "Added "$ch; done
+  $ for ch in a b c d e f g h; do
+  >   echo "foo" >> $ch
+  >   hg ci -Aqm "Added "$ch
+  > done
   $ hg glog
   @  7:ec2426147f0e  Added h
   |