From patchwork Tue Dec 5 22:03:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: D1598: contrib: ban find(1)'s -printf operator, as it is a GNU-ism From: phabricator X-Patchwork-Id: 25947 Message-Id: To: mercurial-devel@mercurial-scm.org Date: Tue, 5 Dec 2017 22:03:35 +0000 durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1598 AFFECTED FILES contrib/check-code.py CHANGE DETAILS To: durin42, #hg-reviewers Cc: mercurial-devel diff --git a/contrib/check-code.py b/contrib/check-code.py --- a/contrib/check-code.py +++ b/contrib/check-code.py @@ -149,6 +149,8 @@ (r'env.*-u', "don't use 'env -u VAR', use 'unset VAR'"), (r'cp.* -r ', "don't use 'cp -r', use 'cp -R'"), (r'grep.* -[ABC]', "don't use grep's context flags"), + (r'find.*-printf', + "don't use 'find -printf', it doesn't exist on BSD find(1)"), ], # warnings [