Patchwork D1595: test-run-tests: do not rebuild hg in the test

login
register
mail settings
Submitter phabricator
Date Dec. 5, 2017, 8:27 p.m.
Message ID <differential-rev-PHID-DREV-tamxqhyw2qrltoprcvwc-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25943/
State Superseded
Headers show

Comments

phabricator - Dec. 5, 2017, 8:27 p.m.
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  https://phab.mercurial-scm.org/rHGd600bda4a3e1ef0dea44c915a3d70f22212a4274 and https://phab.mercurial-scm.org/rHGfc0f3ed071fc3547c991dc6eb4ff03101a90d1fb added code to call `$PYTHON run-tests.py ...`. That
  will rebuild hg, is slow and could have other crashes from setup.py, like:
  
    Unable to find a working hg binary to extract the version from the
    repository tags
  
  Therefore use `run-tests.py -l` instead.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1595

AFFECTED FILES
  tests/test-run-tests.t

CHANGE DETAILS




To: quark, #hg-reviewers
Cc: mercurial-devel
phabricator - Dec. 5, 2017, 10:18 p.m.
durin42 added a comment.


  nice find

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1595

To: quark, #hg-reviewers, durin42
Cc: mercurial-devel

Patch

diff --git a/tests/test-run-tests.t b/tests/test-run-tests.t
--- a/tests/test-run-tests.t
+++ b/tests/test-run-tests.t
@@ -1280,7 +1280,7 @@ 
   $ cp -R tmp tmpp
   $ cp tmp/test-uno.t test-solo.t
 
-  $ $PYTHON $TESTDIR/run-tests.py tmp/ test-solo.t tmpp
+  $ rt tmp/ test-solo.t tmpp
   .....
   # Ran 5 tests, 0 skipped, 0 failed.
   $ rm -rf tmp tmpp
@@ -1303,7 +1303,7 @@ 
   > EOF
 
   $ cd ..
-  $ $PYTHON $TESTDIR/run-tests.py tmp/test-*.t
+  $ rt tmp/test-*.t
   
   --- $TESTTMP/anothertests/tmp/test-folder-fail.t
   +++ $TESTTMP/anothertests/tmp/test-folder-fail.t.err