Patchwork D1583: repoview: consider visibilityexceptions while considering filterrevs

login
register
mail settings
Submitter phabricator
Date Dec. 4, 2017, 2:16 p.m.
Message ID <differential-rev-PHID-DREV-ggrklq2wflqcnngyccyr-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25925/
State Superseded
Headers show

Comments

phabricator - Dec. 4, 2017, 2:16 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1583

AFFECTED FILES
  mercurial/repoview.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel
phabricator - Dec. 19, 2017, 12:23 p.m.
pulkit abandoned this revision.
pulkit added a comment.


  This series is superseded by https://phab.mercurial-scm.org/D1730 - https://phab.mercurial-scm.org/D1735.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1583

To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -71,6 +71,8 @@ 
         pfunc = repo.changelog.parentrevs
         mutablephases = (phases.draft, phases.secret)
         mutable = repo._phasecache.getrevset(repo, mutablephases)
+        # consider visibility exceptions
+        hidden = hidden - repo.filtered(filtername).getvisibilityexceptions()
 
         visible = mutable - hidden
         _revealancestors(pfunc, hidden, visible)