Patchwork test-lfs: drop a hack for ignoring convert devel-warnings

login
register
mail settings
Submitter Matt Harbison
Date Dec. 2, 2017, 3:43 a.m.
Message ID <dd5c3d73534038ae74c5.1512186209@Envy>
Download mbox | patch
Permalink /patch/25889/
State Accepted
Headers show

Comments

Matt Harbison - Dec. 2, 2017, 3:43 a.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1512186055 18000
#      Fri Dec 01 22:40:55 2017 -0500
# Node ID dd5c3d73534038ae74c53e3baf46cabd36818af1
# Parent  2523ab8ba69dfbfd9832f115d9bbc1f9b9ce4745
test-lfs: drop a hack for ignoring convert devel-warnings

This was fixed on stable in 281214150561.
Yuya Nishihara - Dec. 3, 2017, 6:41 a.m.
On Fri, 01 Dec 2017 22:43:29 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1512186055 18000
> #      Fri Dec 01 22:40:55 2017 -0500
> # Node ID dd5c3d73534038ae74c53e3baf46cabd36818af1
> # Parent  2523ab8ba69dfbfd9832f115d9bbc1f9b9ce4745
> test-lfs: drop a hack for ignoring convert devel-warnings

Queued, thanks.

Patch

diff --git a/tests/test-lfs-largefiles.t b/tests/test-lfs-largefiles.t
--- a/tests/test-lfs-largefiles.t
+++ b/tests/test-lfs-largefiles.t
@@ -266,14 +266,8 @@ 
 convert extension under the hood with --to-normal.  So the --config based
 parameters are available, but not --authormap, --branchmap, etc.
 
-XXX: The default configitems are registered in convert.__init__, and I have no
-idea how to load that before lfconvert starts using other convert modules and
-incurring a devel-warn.  Even if the convert extension is enabled on the command
-line, it complains.  I have no idea how this fails, and the test in fcd2f9b06629
-works.
-
   $ cd ..
-  $ hg lfconvert --to-normal largefiles nolargefiles 2>&1 | grep -v 'devel-warn'
+  $ hg lfconvert --to-normal largefiles nolargefiles 2>&1
   initializing destination nolargefiles
   0 additional largefiles cached
   scanning source...