Patchwork D1575: amend: make a copy of "extra" to avoid mutating an input

login
register
mail settings
Submitter phabricator
Date Dec. 1, 2017, 10:43 p.m.
Message ID <differential-rev-PHID-DREV-jge6opz52wqhmgz3gak2-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25873/
State Superseded
Headers show

Comments

phabricator - Dec. 1, 2017, 10:43 p.m.
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I don't know of any problems this has caused, it just seems less
  surprising.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1575

AFFECTED FILES
  mercurial/cmdutil.py

CHANGE DETAILS




To: martinvonz, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/cmdutil.py b/mercurial/cmdutil.py
--- a/mercurial/cmdutil.py
+++ b/mercurial/cmdutil.py
@@ -3137,6 +3137,8 @@ 
         # base     o - first parent of the changeset to amend
         wctx = repo[None]
 
+        # Copy to avoid mutating input
+        extra = extra.copy()
         # Update extra dict from amended commit (e.g. to preserve graft
         # source)
         extra.update(old.extra())