Patchwork D1553: contrib: improve check-code ban on $LOCALIP in output without (glob)

login
register
mail settings
Submitter phabricator
Date Nov. 30, 2017, 12:58 p.m.
Message ID <7dd2ee5a19cf0f811a5afa6075fa5beb@localhost.localdomain>
Download mbox | patch
Permalink /patch/25826/
State Not Applicable
Headers show

Comments

phabricator - Nov. 30, 2017, 12:58 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG273907306a39: contrib: improve check-code ban on $LOCALIP in output without (glob) (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1553?vs=3976&id=4010

REVISION DETAIL
  https://phab.mercurial-scm.org/D1553

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: durin42, #hg-reviewers, lothiraldan, yuja
Cc: lothiraldan, mercurial-devel

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -197,7 +197,7 @@ 
      'write "file:/*/$TESTTMP" + (glob) to match on windows too'),
     (r'^  [^$>].*27\.0\.0\.1',
      'use $LOCALIP not an explicit loopback address'),
-    (r'^  [^$>].*\$LOCALIP.*[^)]$',
+    (r'^  (?![>$] ).*\$LOCALIP.*[^)]$',
      'mark $LOCALIP output lines with (glob) to help tests in BSD jails'),
     (r'^  (cat|find): .*: No such file or directory',
      'use test -f to test for file existence'),