Patchwork D1562: test: fix common-pattern for *BSD systems

login
register
mail settings
Submitter phabricator
Date Nov. 30, 2017, 4:32 a.m.
Message ID <differential-rev-PHID-DREV-b6ezzibkz6bdvrccj6kh-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25821/
State Superseded
Headers show

Comments

phabricator - Nov. 30, 2017, 4:32 a.m.
lothiraldan created this revision.
lothiraldan added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The $USUAL_COMPRESSIONS$ value that was taken was not compatible with *BSD
  systems as zlib seems to not be available on these systems.
  
  This changeset has only been tested on Linux but should fix the pattern for
  *BSD systems.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1562

AFFECTED FILES
  tests/common-pattern.py

CHANGE DETAILS




To: lothiraldan, durin42, #hg-reviewers
Cc: mercurial-devel
phabricator - Nov. 30, 2017, 12:02 p.m.
durin42 added a comment.


  This has nothing to do with BSD, this is a failure on Linux in pure Python
  mode.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1562

To: lothiraldan, durin42, #hg-reviewers
Cc: mercurial-devel
phabricator - Dec. 1, 2017, 10:32 a.m.
lothiraldan added a comment.


  I got confused, I will send an updated version with a fixed changeset message.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1562

To: lothiraldan, durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/tests/common-pattern.py b/tests/common-pattern.py
--- a/tests/common-pattern.py
+++ b/tests/common-pattern.py
@@ -3,7 +3,7 @@ 
 
 substitutions = [
     # list of possible compressions
-    (br'zstd,zlib,none,bzip2',
+    (br'(zstd,)?zlib,none,bzip2',
      br'$USUAL_COMPRESSIONS$'
     ),
     # capabilities sent through http