Patchwork D1553: contrib: improve check-code ban on $LOCALIP in output without (glob)

login
register
mail settings
Submitter phabricator
Date Nov. 29, 2017, 10:09 p.m.
Message ID <differential-rev-PHID-DREV-opydryq62bq7icgmbaxs-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25810/
State Superseded
Headers show

Comments

phabricator - Nov. 29, 2017, 10:09 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1553

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel
phabricator - Nov. 30, 2017, 12:19 a.m.
lothiraldan accepted this revision.
lothiraldan added a comment.


  Looks good, thank you for the fix.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1553

To: durin42, #hg-reviewers, lothiraldan
Cc: lothiraldan, mercurial-devel

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -197,7 +197,7 @@ 
      'write "file:/*/$TESTTMP" + (glob) to match on windows too'),
     (r'^  [^$>].*27\.0\.0\.1',
      'use $LOCALIP not an explicit loopback address'),
-    (r'^  [^$>].*\$LOCALIP.*[^)]$',
+    (r'^  (?![>$] ).*\$LOCALIP.*[^)]$',
      'mark $LOCALIP output lines with (glob) to help tests in BSD jails'),
     (r'^  (cat|find): .*: No such file or directory',
      'use test -f to test for file existence'),