Patchwork [1,of,4] debugshell: add 'db' to cmdtable aliases

login
register
mail settings
Submitter Sean Farley
Date Sept. 20, 2013, 8:28 p.m.
Message ID <a005dc16a698e26612f8.1379708910@laptop.local>
Download mbox | patch
Permalink /patch/2579/
State Deferred
Headers show

Comments

Sean Farley - Sept. 20, 2013, 8:28 p.m.
# HG changeset patch
# User Sean Farley <sean.michael.farley@gmail.com>
# Date 1373819917 18000
#      Sun Jul 14 11:38:37 2013 -0500
# Node ID a005dc16a698e26612f87771548aa65843c40160
# Parent  ea35caf324bb04cbc9ab5e2328367bc50f558cfb
debugshell: add 'db' to cmdtable aliases
Nikolaj Sjujskij - Sept. 20, 2013, 9:20 p.m.
Den 2013-09-21 00:28:30 skrev Sean Farley <sean.michael.farley@gmail.com>:

> # HG changeset patch
> # User Sean Farley <sean.michael.farley@gmail.com>
> # Date 1373819917 18000
> #      Sun Jul 14 11:38:37 2013 -0500
> # Node ID a005dc16a698e26612f87771548aa65843c40160
> # Parent  ea35caf324bb04cbc9ab5e2328367bc50f558cfb
> debugshell: add 'db' to cmdtable aliases
  Isn't `db` commonly recognized as "database"?
Quick Google search for "dbshell" seems to indicate the same ambiguity.


> diff --git a/contrib/debugshell.py b/contrib/debugshell.py
> --- a/contrib/debugshell.py
> +++ b/contrib/debugshell.py
> @@ -15,7 +15,7 @@
>                  "using source: %s" % (repo.root,
>                                        mercurial.__path__[0])
>      code.interact(bannermsg, local=objects)
> cmdtable = {
> -    "debugshell|dbsh": (debugshell, [])
> +    "debugshell|dbsh|db": (debugshell, [])
>  }
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel
Sean Farley - Sept. 20, 2013, 9:35 p.m.
sterkrig@myopera.com writes:

> Den 2013-09-21 00:28:30 skrev Sean Farley <sean.michael.farley@gmail.com>:
>
>> # HG changeset patch
>> # User Sean Farley <sean.michael.farley@gmail.com>
>> # Date 1373819917 18000
>> #      Sun Jul 14 11:38:37 2013 -0500
>> # Node ID a005dc16a698e26612f87771548aa65843c40160
>> # Parent  ea35caf324bb04cbc9ab5e2328367bc50f558cfb
>> debugshell: add 'db' to cmdtable aliases
>   Isn't `db` commonly recognized as "database"?
> Quick Google search for "dbshell" seems to indicate the same ambiguity.

I don't quite follow. Is there a database extension that provides the
'hg db' command?
Nikolaj Sjujskij - Sept. 21, 2013, 9:57 a.m.
Den 2013-09-21 01:35:46 skrev Sean Farley <sean.michael.farley@gmail.com>:

>
> sterkrig@myopera.com writes:
>
>> Den 2013-09-21 00:28:30 skrev Sean Farley  
>> <sean.michael.farley@gmail.com>:
>>
>>> # HG changeset patch
>>> # User Sean Farley <sean.michael.farley@gmail.com>
>>> # Date 1373819917 18000
>>> #      Sun Jul 14 11:38:37 2013 -0500
>>> # Node ID a005dc16a698e26612f87771548aa65843c40160
>>> # Parent  ea35caf324bb04cbc9ab5e2328367bc50f558cfb
>>> debugshell: add 'db' to cmdtable aliases
>>   Isn't `db` commonly recognized as "database"?
>> Quick Google search for "dbshell" seems to indicate the same ambiguity.
>
> I don't quite follow. Is there a database extension that provides the
> 'hg db' command?
  Nope, I just point out that `db` and `dbshell` might be not very apt  
aliases for `debugshell`.
Sean Farley - Sept. 21, 2013, 10:55 p.m.
kbullock+mercurial@ringworld.org writes:

> On 20 Sep 2013, at 3:28 PM, Sean Farley wrote:
>
>> # HG changeset patch
>> # User Sean Farley <sean.michael.farley@gmail.com>
>> # Date 1373819917 18000
>> #      Sun Jul 14 11:38:37 2013 -0500
>> # Node ID a005dc16a698e26612f87771548aa65843c40160
>> # Parent  ea35caf324bb04cbc9ab5e2328367bc50f558cfb
>> debugshell: add 'db' to cmdtable aliases
>> 
>> diff --git a/contrib/debugshell.py b/contrib/debugshell.py
>> --- a/contrib/debugshell.py
>> +++ b/contrib/debugshell.py
>> @@ -15,7 +15,7 @@
>>                 "using source: %s" % (repo.root,
>>                                       mercurial.__path__[0])
>>     code.interact(bannermsg, local=objects)
>> 
>> cmdtable = {
>> -    "debugshell|dbsh": (debugshell, [])
>> +    "debugshell|dbsh|db": (debugshell, [])
>
> I think 'dbsh' is about as short as we can go without confusion. We have aliases if you want to go shorter.

Fair enough. I think the rest of the series should apply even if this
one is dropped (though I haven't tested).
Augie Fackler - Sept. 24, 2013, 8:16 p.m.
On Fri, Sep 20, 2013 at 03:28:30PM -0500, Sean Farley wrote:
> # HG changeset patch
> # User Sean Farley <sean.michael.farley@gmail.com>
> # Date 1373819917 18000
> #      Sun Jul 14 11:38:37 2013 -0500
> # Node ID a005dc16a698e26612f87771548aa65843c40160
> # Parent  ea35caf324bb04cbc9ab5e2328367bc50f558cfb
> debugshell: add 'db' to cmdtable aliases
>
> diff --git a/contrib/debugshell.py b/contrib/debugshell.py
> --- a/contrib/debugshell.py
> +++ b/contrib/debugshell.py
> @@ -15,7 +15,7 @@
>                  "using source: %s" % (repo.root,
>                                        mercurial.__path__[0])
>      code.interact(bannermsg, local=objects)
>
>  cmdtable = {
> -    "debugshell|dbsh": (debugshell, [])
> +    "debugshell|dbsh|db": (debugshell, [])

Seems silly. I would have opposed dbsh if anyone asked me when it was
new.

>  }
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@selenic.com
> http://selenic.com/mailman/listinfo/mercurial-devel

Patch

diff --git a/contrib/debugshell.py b/contrib/debugshell.py
--- a/contrib/debugshell.py
+++ b/contrib/debugshell.py
@@ -15,7 +15,7 @@ 
                 "using source: %s" % (repo.root,
                                       mercurial.__path__[0])
     code.interact(bannermsg, local=objects)
 
 cmdtable = {
-    "debugshell|dbsh": (debugshell, [])
+    "debugshell|dbsh|db": (debugshell, [])
 }