Patchwork D1503: rewriteutil: add a precheck function to check if revs can be rewritten

login
register
mail settings
Submitter phabricator
Date Nov. 28, 2017, 7:14 p.m.
Message ID <eca6288a72aa2571364813e732431021@localhost.localdomain>
Download mbox | patch
Permalink /patch/25783/
State Not Applicable
Headers show

Comments

phabricator - Nov. 28, 2017, 7:14 p.m.
pulkit updated this revision to Diff 3912.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1503?vs=3900&id=3912

REVISION DETAIL
  https://phab.mercurial-scm.org/D1503

AFFECTED FILES
  mercurial/rewriteutil.py

CHANGE DETAILS




To: pulkit, #hg-reviewers, dlax
Cc: mercurial-devel

Patch

diff --git a/mercurial/rewriteutil.py b/mercurial/rewriteutil.py
--- a/mercurial/rewriteutil.py
+++ b/mercurial/rewriteutil.py
@@ -7,11 +7,39 @@ 
 
 from __future__ import absolute_import
 
+from .i18n import _
+
 from . import (
+    error,
+    node,
     obsolete,
     revset,
 )
 
+def precheck(repo, revs, action='rewrite'):
+    """check if revs can be rewritten
+    action is used to control the error message.
+
+    Make sure this function is called after taking the lock.
+    """
+    if node.nullrev in revs:
+        msg = _("cannot %s null changeset") % (action)
+        hint = _("no changeset checked out")
+        raise error.Abort(msg, hint=hint)
+
+    publicrevs = repo.revs('%ld and public()', revs)
+    if len(repo[None].parents()) > 1:
+        raise error.Abort(_("cannot %s while merging") % action)
+
+    if publicrevs:
+        msg = _("cannot %s public changesets") % (action)
+        hint = _("see 'hg help phases' for details")
+        raise error.Abort(msg, hint=hint)
+
+    newunstable = disallowednewunstable(repo, revs)
+    if newunstable:
+        raise error.Abort(_("cannot %s changeset with children") % action)
+
 def disallowednewunstable(repo, revs):
     """Checks whether editing the revs will create new unstable changesets and
     are we allowed to create them.