Patchwork [5,of,5] largefiles: explicitly set the source and sink types to 'hg' for lfconvert

login
register
mail settings
Submitter Matt Harbison
Date Nov. 26, 2017, 10:45 p.m.
Message ID <e251a82c7a7601ce3d7e.1511736305@Envy>
Download mbox | patch
Permalink /patch/25761/
State Accepted
Headers show

Comments

Matt Harbison - Nov. 26, 2017, 10:45 p.m.
# HG changeset patch
# User Matt Harbison <matt_harbison@yahoo.com>
# Date 1511418070 18000
#      Thu Nov 23 01:21:10 2017 -0500
# Node ID e251a82c7a7601ce3d7e4fcccb2b44cb7d599db5
# Parent  1dfe0c6abea0374834bbb100b5402361e9d7954a
largefiles: explicitly set the source and sink types to 'hg' for lfconvert

I stumbled into this prior to adding the type indicator on the source and sink,
but there's no reason to try to infer the types for this conversion.
Augie Fackler - Nov. 30, 2017, 9:01 p.m.
On Sun, Nov 26, 2017 at 05:45:05PM -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison@yahoo.com>
> # Date 1511418070 18000
> #      Thu Nov 23 01:21:10 2017 -0500
> # Node ID e251a82c7a7601ce3d7e4fcccb2b44cb7d599db5
> # Parent  1dfe0c6abea0374834bbb100b5402361e9d7954a
> largefiles: explicitly set the source and sink types to 'hg' for lfconvert

queued, thanks

Seems like good incremental progress on LFS, glad to see this getting attention

Patch

diff --git a/hgext/largefiles/lfcommands.py b/hgext/largefiles/lfcommands.py
--- a/hgext/largefiles/lfcommands.py
+++ b/hgext/largefiles/lfcommands.py
@@ -177,7 +177,7 @@ 
             convcmd.converter = converter
 
             try:
-                convcmd.convert(ui, src, dest)
+                convcmd.convert(ui, src, dest, source_type='hg', dest_type='hg')
             finally:
                 convcmd.converter = orig
         success = True