Submitter | phabricator |
---|---|
Date | Nov. 21, 2017, 7:53 a.m. |
Message ID | <differential-rev-PHID-DREV-dm7aqokjp6e2qzogwc3h-req@phab.mercurial-scm.org> |
Download | mbox | patch |
Permalink | /patch/25705/ |
State | Superseded |
Headers | show |
Comments
pulkit requested changes to this revision. pulkit added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > templatekw.py:610 > + args = pycompat.byteskwargs(args) > succsandmarkers = showsuccsandmarkers(**args) > I think we should swap the order of the above two lines. `args` is passed again as keyword argument. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1479 To: indygreg, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel
indygreg abandoned this revision. indygreg added a comment. This was addressed by https://phab.mercurial-scm.org/D1536. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1479 To: indygreg, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel
Patch
diff --git a/mercurial/templatekw.py b/mercurial/templatekw.py --- a/mercurial/templatekw.py +++ b/mercurial/templatekw.py @@ -606,6 +606,7 @@ # # This function will be replaced by templates fragments when we will have # the verbosity templatekw available. + args = pycompat.byteskwargs(args) succsandmarkers = showsuccsandmarkers(**args) ui = args['ui']