Patchwork D1462: tests: add test for rebase template showing wrong behavior

login
register
mail settings
Submitter phabricator
Date Nov. 20, 2017, 7:04 p.m.
Message ID <differential-rev-PHID-DREV-zwpc7aw435rrau4cchkp-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25672/
State Superseded
Headers show

Comments

phabricator - Nov. 20, 2017, 7:04 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The output for template "{nodechanges % ':{value}'}" does not contain the
  output for value.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1462

AFFECTED FILES
  tests/test-rebase-templates.t

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel
phabricator - Nov. 20, 2017, 11:27 p.m.
durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> test-rebase-templates.t:56
> +
> +  $ hg rebase -s 6 -d 4 -q -T "{nodechanges % '{key}:{value}'}"
> +  d9d6773efc831c274eace04bc13e8e6412517139 (no-eol)

Can you comment what the correct behavior here should be? Yuya had a clever trick of (!true) or something to put the expected output inline with the actual output...

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1462

To: pulkit, #hg-reviewers, durin42
Cc: durin42, mercurial-devel

Patch

diff --git a/tests/test-rebase-templates.t b/tests/test-rebase-templates.t
--- a/tests/test-rebase-templates.t
+++ b/tests/test-rebase-templates.t
@@ -42,3 +42,16 @@ 
   
   $ hg rebase -s 1 -d 5 -q -T "{nodechanges|json}"
   {"29becc82797a4bc11ec8880b58eaecd2ab3e7760": ["d9d6773efc831c274eace04bc13e8e6412517139"]} (no-eol)
+
+  $ hg log -G -T "{rev}:{node|short} {desc}"
+  o  6:d9d6773efc83 Added b
+  |
+  @  5:df21b32134ba Added d
+  |
+  o  4:849767420fd5 Added c
+  |
+  o  0:18d04c59bb5d Added a
+  
+
+  $ hg rebase -s 6 -d 4 -q -T "{nodechanges % '{key}:{value}'}"
+  d9d6773efc831c274eace04bc13e8e6412517139 (no-eol)