D1425: logtoprocess: clean-up old comment

Submitter	phabricator
Date	Nov. 15, 2017, 3:44 p.m.
Message ID	<differential-rev-PHID-DREV-pe22vfs5wjdlsli46zz2-req@phab.mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/25584/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Wed, 15 Nov 2017 15:44:12 +0000 To: mercurial-devel@mercurial-scm.org From: "lothiraldan (Boris Feld)" <phabricator@mercurial-scm.org> Subject: D1425: logtoprocess: clean-up old comment Message-ID: <differential-rev-PHID-DREV-pe22vfs5wjdlsli46zz2-req@phab.mercurial-scm.org> Thread-Topic: D1425: logtoprocess: clean-up old comment Precedence: bulk Thread-Index: MzgzZDk3MGFlNWIyNTI4OTRmNjIwMTU1M2Y2 MIME-Version: 1.0 Reply-To: phabricator+D1425+public+63e2c101730e4956@mercurial-scm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Nov. 15, 2017, 3:44 p.m.

lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The comment was likely to be for runshellcommand code.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1425

AFFECTED FILES
  hgext/logtoprocess.py

CHANGE DETAILS




To: lothiraldan, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/hgext/logtoprocess.py b/hgext/logtoprocess.py
--- a/hgext/logtoprocess.py
+++ b/hgext/logtoprocess.py
@@ -124,8 +124,6 @@ 
                 env = dict(itertools.chain(encoding.environ.items(),
                                            msgpairs, optpairs),
                            EVENT=event, HGPID=str(os.getpid()))
-                # Connect stdin to /dev/null to prevent child processes messing
-                # with mercurial's stdin.
                 runshellcommand(script, env)
             return super(logtoprocessui, self).log(event, *msg, **opts)

Patchwork D1425: logtoprocess: clean-up old comment

Comments

Patch