D1373: bundlerepo: use suffix variable

Submitter	phabricator
Date	Nov. 12, 2017, 2:52 a.m.
Message ID	<differential-rev-PHID-DREV-ymaes5xvtif732rjr3rp-req@phab.mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/25490/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Sun, 12 Nov 2017 02:52:03 +0000 To: mercurial-devel@mercurial-scm.org From: "indygreg (Gregory Szorc)" <phabricator@mercurial-scm.org> Subject: D1373: bundlerepo: use suffix variable Message-ID: <differential-rev-PHID-DREV-ymaes5xvtif732rjr3rp-req@phab.mercurial-scm.org> Thread-Topic: D1373: bundlerepo: use suffix variable Precedence: bulk Thread-Index: MTljNDA4NWFlZGRkYjdhYTE2MDMzNGVjMzdk MIME-Version: 1.0 Reply-To: phabricator+D1373+public+f751031aceb3c1f4@mercurial-scm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Nov. 12, 2017, 2:52 a.m.

indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  It looks like the refactor in https://phab.mercurial-scm.org/rHG702a26fec3e2e85f05af3ebeaf0fc037027ad2b6 attempted to establish
  this method argument but failed to use it. My editor caught it.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1373

AFFECTED FILES
  mercurial/bundlerepo.py

CHANGE DETAILS




To: indygreg, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/bundlerepo.py b/mercurial/bundlerepo.py
--- a/mercurial/bundlerepo.py
+++ b/mercurial/bundlerepo.py
@@ -321,7 +321,7 @@ 
         """Write a temporary file to disk
         """
         fdtemp, temp = self.vfs.mkstemp(prefix="hg-bundle-",
-                                        suffix=".hg10un")
+                                        suffix=suffix)
         self.tempfile = temp
 
         with os.fdopen(fdtemp, pycompat.sysstr('wb')) as fptemp:

Patchwork D1373: bundlerepo: use suffix variable

Comments

Patch