Patchwork [4,of,4] paper: add reddish background to ajax error message

login
register
mail settings
Submitter Alexander Plavin
Date Sept. 19, 2013, 6:31 p.m.
Message ID <f4ce6bc84acbfbd0068e.1379615513@debian-alexander.dolgopa>
Download mbox | patch
Permalink /patch/2539/
State Accepted
Headers show

Comments

Alexander Plavin - Sept. 19, 2013, 6:31 p.m.
# HG changeset patch
# User Alexander Plavin <alexander@plav.in>
# Date 1378459858 -14400
#      Fri Sep 06 13:30:58 2013 +0400
# Node ID f4ce6bc84acbfbd0068e4d4316727524117bdacc
# Parent  35b8522d22eabecbbf2dce93f91442a67c6c3de8
paper: add reddish background to ajax error message
Matt Mackall - Sept. 19, 2013, 8:59 p.m.
On Thu, 2013-09-19 at 22:31 +0400, Alexander Plavin wrote:
> # HG changeset patch
> # User Alexander Plavin <alexander@plav.in>
> # Date 1378459858 -14400
> #      Fri Sep 06 13:30:58 2013 +0400
> # Node ID f4ce6bc84acbfbd0068e4d4316727524117bdacc
> # Parent  35b8522d22eabecbbf2dce93f91442a67c6c3de8
> paper: add reddish background to ajax error message

I've queued 1, 2, and 4 for default, thanks. Not super-excited about the
dividing line in my testing.
Alexander Plavin - Sept. 20, 2013, 7:51 a.m.
20.09.2013, 00:59, "Matt Mackall" <mpm@selenic.com>:
> On Thu, 2013-09-19 at 22:31 +0400, Alexander Plavin wrote:
>
>>  # HG changeset patch
>>  # User Alexander Plavin <alexander@plav.in>
>>  # Date 1378459858 -14400
>>  #      Fri Sep 06 13:30:58 2013 +0400
>>  # Node ID f4ce6bc84acbfbd0068e4d4316727524117bdacc
>>  # Parent  35b8522d22eabecbbf2dce93f91442a67c6c3de8
>>  paper: add reddish background to ajax error message
>
> I've queued 1, 2, and 4 for default, thanks. Not super-excited about the
> dividing line in my testing.

In my opinion, having such a line helps not to lose track when scrolling, especially multiple times. However, feel free not to include that patch - it's only cosmetic change, nothing else depend on it and such or slightly different thing can easily be done later.

>
> --
> Mathematics is the supreme nostalgia of our time.

Patch

diff -r 35b8522d22ea -r f4ce6bc84acb mercurial/templates/static/style-paper.css
--- a/mercurial/templates/static/style-paper.css	Fri Sep 06 13:30:58 2013 +0400
+++ b/mercurial/templates/static/style-paper.css	Fri Sep 06 13:30:58 2013 +0400
@@ -403,6 +403,10 @@ 
   from { background-color: #A0CEFF; } to {  }
 }
 
+.scroll-loading-error {
+    background-color: #FFCCCC !important;
+}
+
 .scroll-separator {
     border-bottom: 1px solid #444 !important;
 }