Patchwork D1287: repoview: add two new filternames to be used for accessing hidden commits

login
register
mail settings
Submitter phabricator
Date Nov. 2, 2017, 6:09 p.m.
Message ID <differential-rev-PHID-DREV-35bb6clg4i2c4ps5jtku-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25356/
State Superseded
Headers show

Comments

phabricator - Nov. 2, 2017, 6:09 p.m.
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  This patch adds two new filternames 'visible-hidden' and 'visible-warnhidden'
  which will be used to access hidden commits.
  'visible-hidden' will allow access of hidden commits with any warning. This will
  be for read only commands.
  'visible-warnhidden' will allow acces of hidden commits but will warn for that.
  This will be for recoverable write commands.
  For unrecoverable write commands, we don't need to have anything new as that's
  the current behaviour.
  
  We are using the same computehidden() function as we will be adding the hidden
  revisions to pinnedrevs.
  
  The idea to add new filternames is taken from directaccess extension from
  fb-hgext.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1287

AFFECTED FILES
  mercurial/branchmap.py
  mercurial/repoview.py

CHANGE DETAILS




To: pulkit, #hg-reviewers
Cc: mercurial-devel
phabricator - Dec. 19, 2017, 12:23 p.m.
pulkit abandoned this revision.
pulkit added a comment.


  This series is superseded by https://phab.mercurial-scm.org/D1730 - https://phab.mercurial-scm.org/D1735.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1287

To: pulkit, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/repoview.py b/mercurial/repoview.py
--- a/mercurial/repoview.py
+++ b/mercurial/repoview.py
@@ -142,6 +142,8 @@ 
 # Otherwise your filter will have to recompute all its branches cache
 # from scratch (very slow).
 filtertable = {'visible': computehidden,
+               'visible-warnhidden': computehidden,
+               'visible-hidden': computehidden,
                'served': computeunserved,
                'immutable':  computemutable,
                'base':  computeimpactable}
diff --git a/mercurial/branchmap.py b/mercurial/branchmap.py
--- a/mercurial/branchmap.py
+++ b/mercurial/branchmap.py
@@ -86,7 +86,9 @@ 
 subsettable = {None: 'visible',
                'visible': 'served',
                'served': 'immutable',
-               'immutable': 'base'}
+               'immutable': 'base',
+               'visible-warnhidden': 'visible',
+               'visible-hidden': 'visible'}
 
 def updatecache(repo):
     cl = repo.changelog