Patchwork mq: remove unused repo._committingpatch-related code

login
register
mail settings
Submitter Brodie Rao
Date Sept. 19, 2013, 12:20 a.m.
Message ID <11fdf9f754b78d04abe8.1379550022@kapp.staff.sf.atlassian.com>
Download mbox | patch
Permalink /patch/2534/
State Accepted
Headers show

Comments

Brodie Rao - Sept. 19, 2013, 12:20 a.m.
# HG changeset patch
# User Brodie Rao <brodie@sf.io>
# Date 1379318909 25200
#      Mon Sep 16 01:08:29 2013 -0700
# Node ID 11fdf9f754b78d04abe81430607f292d1a04aa2c
# Parent  d4ed26beae0e41c86c413c69c1e6f13c32eb3d33
mq: remove unused repo._committingpatch-related code

This was introduced in 20ad8f0512a2 but its usage was removed in
46cc3b74e1c5.
Matt Mackall - Sept. 19, 2013, 1:17 a.m.
On Wed, 2013-09-18 at 17:20 -0700, Brodie Rao wrote:
> # HG changeset patch
> # User Brodie Rao <brodie@sf.io>
> # Date 1379318909 25200
> #      Mon Sep 16 01:08:29 2013 -0700
> # Node ID 11fdf9f754b78d04abe81430607f292d1a04aa2c
> # Parent  d4ed26beae0e41c86c413c69c1e6f13c32eb3d33
> mq: remove unused repo._committingpatch-related code

Queued for default, thanks.

Patch

diff --git a/hgext/mq.py b/hgext/mq.py
--- a/hgext/mq.py
+++ b/hgext/mq.py
@@ -283,15 +283,11 @@  def newcommit(repo, phase, *args, **kwar
             phase = phases.secret
     if phase is not None:
         backup = repo.ui.backupconfig('phases', 'new-commit')
-    # Marking the repository as committing an mq patch can be used
-    # to optimize operations like branchtags().
-    repo._committingpatch = True
     try:
         if phase is not None:
             repo.ui.setconfig('phases', 'new-commit', phase)
         return repo.commit(*args, **kwargs)
     finally:
-        repo._committingpatch = False
         if phase is not None:
             repo.ui.restoreconfig(backup)