Patchwork scripts: warn about invalid MAINTAINERS patterns

login
register
mail settings
Submitter Joe Perches
Date Nov. 1, 2017, 4:50 p.m.
Message ID <1509555005.31043.43.camel@perches.com>
Download mbox | patch
Permalink /patch/25318/
State Not Applicable
Headers show

Comments

Joe Perches - Nov. 1, 2017, 4:50 p.m.
(add mercurial-devel and xen-devel to cc's)

On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
> Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
> "F" and "X" patterns found in MAINTAINERS file(s).

Hey again Tom.

About mercurial/hg.

While as far as I know there hasn't been a mercurial tree
for the linux kernel sources in many years, I believe the
mercurial command to list files should be different.

> my %VCS_cmds_hg = (
> @@ -167,6 +169,7 @@ my %VCS_cmds_hg = (
>      "subject_pattern" => "^HgSubject: (.*)",
>      "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
>      "file_exists_cmd" => "hg files \$file",
> +    "list_files_cmd" => "hg files \$file",

I think this should be

	"list_files_cmd" => "hg manifest -R \$file",

It seems to work on a XEN test branch but does anyone
really care about hg support in get_maintainers?

btw: to the XEN maintainers

The XEN mercurial branch for MAINTAINERS has a few odd
entries and a few missing file patterns

I think the XEN MAINTAINERS file should be updated to:

---
---

After the patch above is applied, --self-test shows:

$ ~/linux/next/scripts/get_maintainer.pl --self-test
./MAINTAINERS:403:	warning: no matches	F:	drivers/xen/usb*/
./MAINTAINERS:415:	warning: no matches	F:	xen/arch/x88/hvm/vm_event.c
./MAINTAINERS:429:	warning: no matches	F:	extras/mini-os/tpm*
./MAINTAINERS:430:	warning: no matches	F:	extras/mini-os/include/tpm*
Tom Saeger - Nov. 1, 2017, 5:11 p.m.
On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote:
> (add mercurial-devel and xen-devel to cc's)
> 
> On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
> > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
> > "F" and "X" patterns found in MAINTAINERS file(s).
> 
> Hey again Tom.
> 
> About mercurial/hg.
> 
> While as far as I know there hasn't been a mercurial tree
> for the linux kernel sources in many years, I believe the
> mercurial command to list files should be different.
> 
> > my %VCS_cmds_hg = (
> > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = (
> >      "subject_pattern" => "^HgSubject: (.*)",
> >      "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
> >      "file_exists_cmd" => "hg files \$file",
> > +    "list_files_cmd" => "hg files \$file",
> 
> I think this should be
> 
> 	"list_files_cmd" => "hg manifest -R \$file",

Ok - I'll add to v2.
Augie Fackler - Nov. 1, 2017, 8:05 p.m.
> On Nov 1, 2017, at 13:11, Tom Saeger <tom.saeger@oracle.com> wrote:
> 
> On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote:
>> (add mercurial-devel and xen-devel to cc's)
>> 
>> On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
>>> Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
>>> "F" and "X" patterns found in MAINTAINERS file(s).
>> 
>> Hey again Tom.
>> 
>> About mercurial/hg.
>> 
>> While as far as I know there hasn't been a mercurial tree
>> for the linux kernel sources in many years, I believe the
>> mercurial command to list files should be different.
>> 
>>> my %VCS_cmds_hg = (
>>> @@ -167,6 +169,7 @@ my %VCS_cmds_hg = (
>>>     "subject_pattern" => "^HgSubject: (.*)",
>>>     "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
>>>     "file_exists_cmd" => "hg files \$file",
>>> +    "list_files_cmd" => "hg files \$file",
>> 
>> I think this should be
>> 
>> 	"list_files_cmd" => "hg manifest -R \$file",
> 
> Ok - I'll add to v2.

Actually, I'd recommend `hg files` over `hg manifest` by a wide margin.

> 
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel@mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Joe Perches - Nov. 1, 2017, 8:24 p.m.
On Wed, 2017-11-01 at 16:05 -0400, Augie Fackler wrote:
> > On Nov 1, 2017, at 13:11, Tom Saeger <tom.saeger@oracle.com> wrote:
> > 
> > On Wed, Nov 01, 2017 at 09:50:05AM -0700, Joe Perches wrote:
> > > (add mercurial-devel and xen-devel to cc's)
> > > 
> > > On Tue, 2017-10-31 at 16:37 -0500, Tom Saeger wrote:
> > > > Add "--pattern-checks" option to get_maintainer.pl to warn about invalid
> > > > "F" and "X" patterns found in MAINTAINERS file(s).
> > > 
> > > Hey again Tom.
> > > 
> > > About mercurial/hg.
> > > 
> > > While as far as I know there hasn't been a mercurial tree
> > > for the linux kernel sources in many years, I believe the
> > > mercurial command to list files should be different.
> > > 
> > > > my %VCS_cmds_hg = (
> > > > @@ -167,6 +169,7 @@ my %VCS_cmds_hg = (
> > > >     "subject_pattern" => "^HgSubject: (.*)",
> > > >     "stat_pattern" => "^(\\d+)\t(\\d+)\t\$file\$",
> > > >     "file_exists_cmd" => "hg files \$file",
> > > > +    "list_files_cmd" => "hg files \$file",
> > > 
> > > I think this should be
> > > 
> > > 	"list_files_cmd" => "hg manifest -R \$file",
> > 
> > Ok - I'll add to v2.
> 
> Actually, I'd recommend `hg files` over `hg manifest` by a wide margin.

why?

hg files -R <path> prefixes all the output
hg manifest -R <path> output is unprefixed
Joe Perches - Nov. 1, 2017, 8:52 p.m.
On Wed, 2017-11-01 at 15:38 -0500, Kevin Bullock wrote:
> (remove other mailing lists from cc)
> 
> > On Nov 1, 2017, at 15:24, Joe Perches <joe@perches.com> wrote:
> > 
> > On Wed, 2017-11-01 at 16:05 -0400, Augie Fackler wrote:
> > > Actually, I'd recommend `hg files` over `hg manifest` by a wide margin.
> > 
> > why?
> > 
> > hg files -R <path> prefixes all the output
> > hg manifest -R <path> output is unprefixed
> 
> That's intended behavior, but perhaps you want `hg files --cwd <path>`?

I fail to see the difference.
Augie Fackler - Nov. 1, 2017, 8:55 p.m.
> On Nov 1, 2017, at 16:52, Joe Perches <joe@perches.com> wrote:
> 
> On Wed, 2017-11-01 at 15:38 -0500, Kevin Bullock wrote:
>> (remove other mailing lists from cc)
>> 
>>> On Nov 1, 2017, at 15:24, Joe Perches <joe@perches.com> wrote:
>>> 
>>> On Wed, 2017-11-01 at 16:05 -0400, Augie Fackler wrote:
>>>> Actually, I'd recommend `hg files` over `hg manifest` by a wide margin.
>>> 
>>> why?
>>> 
>>> hg files -R <path> prefixes all the output
>>> hg manifest -R <path> output is unprefixed
>> 
>> That's intended behavior, but perhaps you want `hg files --cwd <path>`?
> 
> I fail to see the difference.

`hg files` is the command we'll be working on and improving in the future. `hg manifest` won't be going away, but also won't gain any performance wins or nice new features except accidentally.

But it's really up to you. I don't feel strongly, and our backwards compatibility story is strong enough if you use `hg manifest` you shouldn't ever need to care we deprecated it several years ago.
Joe Perches - Nov. 1, 2017, 9:05 p.m.
On Wed, 2017-11-01 at 16:55 -0400, Augie Fackler wrote:
> > On Nov 1, 2017, at 16:52, Joe Perches <joe@perches.com> wrote:
> > 
> > On Wed, 2017-11-01 at 15:38 -0500, Kevin Bullock wrote:
> > > (remove other mailing lists from cc)
> > > 
> > > > On Nov 1, 2017, at 15:24, Joe Perches <joe@perches.com> wrote:
> > > > 
> > > > On Wed, 2017-11-01 at 16:05 -0400, Augie Fackler wrote:
> > > > > Actually, I'd recommend `hg files` over `hg manifest` by a wide margin.
> > > > 
> > > > why?
> > > > 
> > > > hg files -R <path> prefixes all the output
> > > > hg manifest -R <path> output is unprefixed
> > > 
> > > That's intended behavior, but perhaps you want `hg files --cwd <path>`?
> > 
> > I fail to see the difference.
> 
> `hg files` is the command we'll be working on and improving in the future. `hg manifest` won't be going away, but also won't gain any performance wins or nice new features except accidentally.

I don't want it to.
Output compatible to git ls-files is all that's necessary.

> But it's really up to you. I don't feel strongly, and our backwards compatibility story is strong enough if you use `hg manifest` you shouldn't ever need to care we deprecated it several years ago.

Good.

Patch

diff -r c60f04b73240 MAINTAINERS
--- a/MAINTAINERS	Mon Oct 16 15:24:44 2017 +0100
+++ b/MAINTAINERS	Wed Nov 01 09:39:34 2017 -0700
@@ -246,7 +246,8 @@ 
 KCONFIG
 M:	Doug Goldstein <cardoe@cardoe.com>
 S:	Supported
-F:	docs/misc/kconfig{,-language}.txt
+F:	docs/misc/kconfig.txt
+F:	docs/misc/kconfig-language.txt
 F:	xen/tools/kconfig/
 
 KDD DEBUGGER
@@ -257,8 +258,8 @@ 
 KEXEC
 M:      Andrew Cooper <andrew.cooper3@citrix.com>
 S:      Supported
-F:      xen/common/{kexec,kimage}.c
-F:      xen/include/{kexec,kimage}.h
+F:      xen/common/kexec.[ch]
+F:      xen/common/kimage.[ch]
 F:      xen/arch/x86/machine_kexec.c
 F:      xen/arch/x86/x86_64/kexec_reloc.S