Patchwork D1128: test-pager: make the test compatible with chg

login
register
mail settings
Submitter phabricator
Date Oct. 17, 2017, 12:42 a.m.
Message ID <differential-rev-PHID-DREV-kby3dzaajivdundjip7l-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25040/
State Superseded
Headers show

Comments

phabricator - Oct. 17, 2017, 12:42 a.m.
singhsrb created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  https://phab.mercurial-scm.org/D911 tried to make this test compatible with chg but instead resulted
  in the test being flaky for chg. For now, disabling this test for chg because
  it seems difficult to fix the test. This will allow for the continuous build
  setup for chg.

TEST PLAN
  Ran the test 'test-pager.t' with and without the '--chg' option.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1128

AFFECTED FILES
  tests/test-pager.t

CHANGE DETAILS




To: singhsrb, #hg-reviewers
Cc: mercurial-devel
phabricator - Oct. 17, 2017, 1:29 a.m.
quark accepted this revision.
quark added a comment.


  This was suggested by me. Basically there are too many "racy" cases that errors can happen everywhere, ex. chg cannot send fds, etc. And the "killed!" output is also racy that it may appear before or after a chg error message.
  
  Instead of trying to match all possible outputs, it is cleaner to just remove the test until we implement something similar to core hg to not execute the shell.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1128

To: singhsrb, #hg-reviewers, quark
Cc: quark, mercurial-devel
phabricator - Oct. 17, 2017, 1:33 a.m.
durin42 added a comment.


  It's probably worth pointing out that the "killed!" message is racy on solaris, which probably means it's just straight-up racy and Linux/FreeBSD/OS X aren't annoying enough to trigger the race on a regular basis....

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1128

To: singhsrb, #hg-reviewers, quark
Cc: durin42, quark, mercurial-devel

Patch

diff --git a/tests/test-pager.t b/tests/test-pager.t
--- a/tests/test-pager.t
+++ b/tests/test-pager.t
@@ -216,16 +216,6 @@ 
   date:        Thu Jan 01 00:00:00 1970 +0000
   summary:     modify a 8
   
-#else
-Currently, chg has its own runpager implementation, which does not show the
-"missing pager" message. The error message is globed out since the shell could
-print different message.
-  $ hg log --limit 3 --config pager.pager=this-command-better-never-exist
-  /bin/sh: this-command-better-never-exist: command not found (?)
-  * (glob) (?)
-  killed!
-  [255]
-
 #endif
 
 A complicated pager command gets worse behavior. Bonus points if you can