Patchwork D1114: contrib: remove check-code rule about indentation

login
register
mail settings
Submitter phabricator
Date Oct. 16, 2017, 3:53 p.m.
Message ID <differential-rev-PHID-DREV-vjwtszvta6sonihxsqkv-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/25000/
State Superseded
Headers show

Comments

phabricator - Oct. 16, 2017, 3:53 p.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We're moving towards a clang-format world, and clang-format is able to
  wrap argument lists with spaces reliably, while still enforcing tabs
  globally. Let's let clang-format do its job, and not do as much
  C-style enforcement with regular expressions.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1114

AFFECTED FILES
  contrib/check-code.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/contrib/check-code.py b/contrib/check-code.py
--- a/contrib/check-code.py
+++ b/contrib/check-code.py
@@ -429,7 +429,6 @@ 
 cpats = [
   [
     (r'//', "don't use //-style comments"),
-    (r'^  ', "don't use spaces to indent"),
     (r'\S\t', "don't use tabs except for indent"),
     (r'(\S[ \t]+|^[ \t]+)\n', "trailing whitespace"),
     (r'.{81}', "line too long"),