Patchwork configitems: fixup default value of annotate config option

login
register
mail settings
Submitter Boris Feld
Date Oct. 16, 2017, 1:43 p.m.
Message ID <b3c7b74f19ba08ef8c2b.1508161424@FB>
Download mbox | patch
Permalink /patch/24986/
State Accepted
Headers show

Comments

Boris Feld - Oct. 16, 2017, 1:43 p.m.
# HG changeset patch
# User Boris Feld <boris.feld@octobus.net>
# Date 1508159570 -7200
#      Mon Oct 16 15:12:50 2017 +0200
# Node ID b3c7b74f19ba08ef8c2b4056508cc1f287550587
# Parent  330d0b582ab38d35d9d521626e9d039044f38ecd
# EXP-Topic config.register.fixup
# Available At https://bitbucket.org/octobus/mercurial-devel/
#              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r b3c7b74f19ba
configitems: fixup default value of annotate config option

It turned out that configbool is used for most of them so the registered
default value was wrong.
Yuya Nishihara - Oct. 16, 2017, 1:54 p.m.
On Mon, 16 Oct 2017 15:43:44 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld <boris.feld@octobus.net>
> # Date 1508159570 -7200
> #      Mon Oct 16 15:12:50 2017 +0200
> # Node ID b3c7b74f19ba08ef8c2b4056508cc1f287550587
> # Parent  330d0b582ab38d35d9d521626e9d039044f38ecd
> # EXP-Topic config.register.fixup
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r b3c7b74f19ba
> configitems: fixup default value of annotate config option

Queued, thanks.

Patch

diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -104,34 +104,34 @@ 
     generic=True,
 )
 coreconfigitem('annotate', 'nodates',
-    default=None,
+    default=False,
 )
 coreconfigitem('annotate', 'showfunc',
-    default=None,
+    default=False,
 )
 coreconfigitem('annotate', 'unified',
     default=None,
 )
 coreconfigitem('annotate', 'git',
-    default=None,
+    default=False,
 )
 coreconfigitem('annotate', 'ignorews',
-    default=None,
+    default=False,
 )
 coreconfigitem('annotate', 'ignorewsamount',
-    default=None,
+    default=False,
 )
 coreconfigitem('annotate', 'ignoreblanklines',
-    default=None,
+    default=False,
 )
 coreconfigitem('annotate', 'ignorewseol',
-    default=None,
+    default=False,
 )
 coreconfigitem('annotate', 'nobinary',
-    default=None,
+    default=False,
 )
 coreconfigitem('annotate', 'noprefix',
-    default=None,
+    default=False,
 )
 coreconfigitem('auth', 'cookiefile',
     default=None,