D1102: wireproto: use %d to encode int, not %s

Submitter	phabricator
Date	Oct. 16, 2017, 1:30 a.m.
Message ID	<differential-rev-PHID-DREV-aqdsjrngag5bjtkohhdz-req@phab.mercurial-scm.org>
Download	mbox \| patch
Permalink	/patch/24961/
State	Superseded
Headers	show Return-Path: <mercurial-devel-bounces@mercurial-scm.org> Date: Mon, 16 Oct 2017 01:30:59 +0000 To: mercurial-devel@mercurial-scm.org From: "durin42 (Augie Fackler)" <phabricator@mercurial-scm.org> Subject: D1102: wireproto: use %d to encode int, not %s Message-ID: <differential-rev-PHID-DREV-aqdsjrngag5bjtkohhdz-req@phab.mercurial-scm.org> Thread-Topic: D1102: wireproto: use %d to encode int, not %s Precedence: bulk Thread-Index: Nzg2NzBmMGE2ZjA5YmVlZmQ5ZjU4YTBjY2Ez MIME-Version: 1.0 Reply-To: phabricator+D1102+public+179064bcc0d6bf55@mercurial-scm.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: mercurial-devel-bounces@mercurial-scm.org Sender: "Mercurial-devel" <mercurial-devel-bounces@mercurial-scm.org>

Comments

phabricator - Oct. 16, 2017, 1:30 a.m.

durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1102

AFFECTED FILES
  mercurial/wireproto.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

phabricator - Oct. 16, 2017, 9:15 a.m.

ryanmce accepted this revision.
ryanmce added a comment.
This revision is now accepted and ready to land.


  queued

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1102

To: durin42, #hg-reviewers, ryanmce
Cc: ryanmce, mercurial-devel

Patch

diff --git a/mercurial/wireproto.py b/mercurial/wireproto.py
--- a/mercurial/wireproto.py
+++ b/mercurial/wireproto.py
@@ -907,7 +907,7 @@ 
     except Exception as inst:
         r = str(inst)
         success = 0
-    return "%s %s\n" % (success, r)
+    return "%d %s\n" % (success, r)
 
 @wireprotocommand('known', 'nodes *')
 def known(repo, proto, nodes, others):

Patchwork D1102: wireproto: use %d to encode int, not %s

Comments

Patch