Patchwork D1092: peer: when collecting method names for batch calls, bytes-ify __name__

login
register
mail settings
Submitter phabricator
Date Oct. 15, 2017, 1:27 p.m.
Message ID <c31eaaa8fa6f34e125fbbf7cf1f7ec26@localhost.localdomain>
Download mbox | patch
Permalink /patch/24946/
State Not Applicable
Headers show

Comments

phabricator - Oct. 15, 2017, 1:27 p.m.
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa652b7763f66: peer: when collecting method names for batch calls, bytes-ify __name__ (authored by durin42, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D1092?vs=2772&id=2782

REVISION DETAIL
  https://phab.mercurial-scm.org/D1092

AFFECTED FILES
  mercurial/peer.py

CHANGE DETAILS




To: durin42, #hg-reviewers, yuja
Cc: mercurial-devel

Patch

diff --git a/mercurial/peer.py b/mercurial/peer.py
--- a/mercurial/peer.py
+++ b/mercurial/peer.py
@@ -34,7 +34,9 @@ 
     def __getattr__(self, name):
         def call(*args, **opts):
             resref = future()
-            self.calls.append((name, args, opts, resref,))
+            # Please don't invent non-ascii method names, or you will
+            # give core hg a very sad time.
+            self.calls.append((name.encode('ascii'), args, opts, resref,))
             return resref
         return call
     def submit(self):