Patchwork D1089: httppeer: convert request url back to bytes before inspecting it

login
register
mail settings
Submitter phabricator
Date Oct. 15, 2017, 4:57 a.m.
Message ID <differential-rev-PHID-DREV-7hcxdn6bqpcxmxpnsm7v-req@phab.mercurial-scm.org>
Download mbox | patch
Permalink /patch/24935/
State Superseded
Headers show

Comments

phabricator - Oct. 15, 2017, 4:57 a.m.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1089

AFFECTED FILES
  mercurial/httppeer.py

CHANGE DETAILS




To: durin42, #hg-reviewers
Cc: mercurial-devel

Patch

diff --git a/mercurial/httppeer.py b/mercurial/httppeer.py
--- a/mercurial/httppeer.py
+++ b/mercurial/httppeer.py
@@ -303,7 +303,7 @@ 
         _wraphttpresponse(resp)
 
         # record the url we got redirected to
-        resp_url = resp.geturl()
+        resp_url = pycompat.bytesurl(resp.geturl())
         if resp_url.endswith(qs):
             resp_url = resp_url[:-len(qs)]
         if self._url.rstrip('/') != resp_url.rstrip('/'):