| Submitter | phabricator |
|---|---|
| Date | Oct. 14, 2017, 7:05 a.m. |
| Message ID | <differential-rev-PHID-DREV-kxer3fkv2lheiemrd3ex-req@phab.mercurial-scm.org> |
| Download | mbox | patch |
| Permalink | /patch/24884/ |
| State | Superseded |
| Headers | show |
Comments
abuehl added inline comments. INLINE COMMENTS > bitmanipulation.h:34 > c[2] = (x >> 8) & 0xff; > - c[3] = (x) & 0xff; > + c[3] = (x)&0xff; > } this one looks bad REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1069 To: durin42, #hg-reviewers Cc: abuehl, mercurial-devel
durin42 marked an inline comment as done. durin42 added inline comments. INLINE COMMENTS > abuehl wrote in bitmanipulation.h:34 > this one looks bad Won't fix: the point of clang-format is that if we want to change how things are formatted, we should do so by adjusting the formatter config, not by hand-tuning things. (Presumably there's a way to change the spelling of this line to format better, or else to tweak clang-format config, but that's not the goal of this patch series.) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1069 To: durin42, #hg-reviewers Cc: abuehl, mercurial-devel
Patch
diff --git a/mercurial/bitmanipulation.h b/mercurial/bitmanipulation.h --- a/mercurial/bitmanipulation.h +++ b/mercurial/bitmanipulation.h @@ -9,34 +9,29 @@ { const unsigned char *d = (const unsigned char *)c; - return ((d[0] << 24) | - (d[1] << 16) | - (d[2] << 8) | - (d[3])); + return ((d[0] << 24) | (d[1] << 16) | (d[2] << 8) | (d[3])); } static inline int16_t getbeint16(const char *c) { const unsigned char *d = (const unsigned char *)c; - return ((d[0] << 8) | - (d[1])); + return ((d[0] << 8) | (d[1])); } static inline uint16_t getbeuint16(const char *c) { const unsigned char *d = (const unsigned char *)c; - return ((d[0] << 8) | - (d[1])); + return ((d[0] << 8) | (d[1])); } static inline void putbe32(uint32_t x, char *c) { c[0] = (x >> 24) & 0xff; c[1] = (x >> 16) & 0xff; c[2] = (x >> 8) & 0xff; - c[3] = (x) & 0xff; + c[3] = (x)&0xff; } static inline double getbefloat64(const char *c) @@ -46,7 +41,7 @@ int i; uint64_t t = 0; for (i = 0; i < 8; i++) { - t = (t<<8) + d[i]; + t = (t << 8) + d[i]; } memcpy(&ret, &t, sizeof(t)); return ret;